Lei Zhang (Gerrit)

unread,

Jul 29, 2025, 2:32:34 PMJul 29

to Joshua Peraza, Lei Zhang, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lei Zhang . resolved

Whoops, I failed to actually hit send.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jul 29, 2025, 2:32:34 PMJul 29

to Joshua Peraza, Lei Zhang, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza

Lei Zhang added 1 comment

Commit Message

Line 9, Patchset 2 (Latest):Upstreams https://chromium-review.googlesource.com/c/chromium/src/+/6785872

Lei Zhang . resolved

If you want to shorten this too: https://crrev.com/c/6785872

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joshua Peraza (Gerrit)

unread,

Jul 29, 2025, 3:05:09 PMJul 29

to Lei Zhang, Crashpad LUCI CQ, crashp...@chromium.org

Joshua Peraza voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Crashpad LUCI CQ (Gerrit)

unread,

Jul 29, 2025, 3:30:25 PMJul 29

to Joshua Peraza, Lei Zhang, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:

Run gn format on BUILD.gn files

Upstreams https://chromium-review.googlesource.com/c/chromium/src/+/6785872

Change-Id: I268b7c6ddd160cb759fae6ddd67b63dcfd3ad6c1

Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6788464

Reviewed-by: Lei Zhang <the...@chromium.org>

Commit-Queue: Joshua Peraza <jpe...@chromium.org>

Files:

M client/BUILD.gn
M handler/BUILD.gn
M handler/win/wer/BUILD.gn
M minidump/BUILD.gn
M snapshot/BUILD.gn
M test/BUILD.gn
M test/ios/BUILD.gn
M util/BUILD.gn

Change size: S

Delta: 8 files changed, 20 insertions(+), 20 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Run gn format on BUILD.gn files [crashpad/crashpad : main]

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Joshua Peraza (Gerrit)

Joshua Peraza voted Commit-Queue+2

Related details

Crashpad LUCI CQ (Gerrit)

Crashpad LUCI CQ submitted the change

Change information