[gtest] Clean up single-arg `testing::Invoke()`s [crashpad/crashpad : main]

10 views
Skip to first unread message

Jonathan Lee (Gerrit)

unread,
Sep 18, 2025, 6:10:46 PM (7 days ago) Sep 18
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Iab29eb0c56fbff4adee5a3312759266956686648
Gerrit-Change-Number: 6967548
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 21:52:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Sep 18, 2025, 6:11:24 PM (7 days ago) Sep 18
to Jonathan Lee, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Jonathan Lee

Mark Mentovai voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Iab29eb0c56fbff4adee5a3312759266956686648
Gerrit-Change-Number: 6967548
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 22:11:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Sep 18, 2025, 6:11:35 PM (7 days ago) Sep 18
to Jonathan Lee, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
[gtest] Clean up single-arg `testing::Invoke()`s

Not needed and deprecated [0]. This CL should be a no-op.

[0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046
Bug: 439838457
Change-Id: Iab29eb0c56fbff4adee5a3312759266956686648
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M util/mach/notify_server_test.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Iab29eb0c56fbff4adee5a3312759266956686648
Gerrit-Change-Number: 6967548
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages