Fix Fuchsia roller tests [crashpad/crashpad : main]
7 views
Skip to first unread message
Thomas Gales (Gerrit)
Feb 3, 2026, 2:34:05 PMFeb 3
to Joshua Peraza, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza and Mark Mentovai
Thomas Gales added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Gales . resolved
Sorry, incorrectly assumed that it was just a build issue. Lesson learned.
Related details
Attention is currently required from:
- Joshua Peraza
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Feb 3, 2026, 2:51:10 PMFeb 3
to Thomas Gales, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza and Thomas Gales
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joshua Peraza
- Thomas Gales
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
Feb 9, 2026, 2:44:44 PMFeb 9
to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza
Thomas Gales added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Thomas Gales . resolved
@jpe...@chromium.org just checking in in case this got lost- unfortunately CLs require two reviewers now
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Feb 9, 2026, 2:53:01 PMFeb 9
to Thomas Gales, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Thomas Gales
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Gales
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
Feb 9, 2026, 3:03:14 PMFeb 9
to Joshua Peraza, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Thomas Gales voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Feb 9, 2026, 3:35:09 PMFeb 9
to Thomas Gales, Joshua Peraza, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix Fuchsia roller tests
Change If1eb1658ce238aae67a95ec15107c6ee5796a8c9 wasn't thorough enough.
It built, but the tests did not pass.
Fixed: 477270789
Test: `fx test //third_party/crashpad/src`
Change-Id: I37175ff307cd6ef84c01ab70c612335875cbad45
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Thomas Gales <tga...@google.com>
Files:
- M util/BUILD.gn
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai, +1 by Joshua Peraza
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages