SetErrorMode() in fastfail tests [crashpad/crashpad : main]

Alex Gough (Gerrit)

unread,

Jun 23, 2023, 4:32:27 PM6/23/23

to Alex Gough, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

Patch set 5:Commit-Queue +1

View Change

2 comments:

Patchset:
- Patch Set #4:
  hey mark - I can't get this working on the bots (the times it does pass the tests just don't seem to have run - perhaps because there is a mix of Windows versions on the bot farm?)
  This small change allows the tests to work locally which is at least some progress.
File handler/win/fastfail_test_program.cc:
- Patch Set #2, Line 129: std::ignore = SetErrorMode(0);
  This doesn’t really have a declaration that requires the use of `std::ignore`, does it?
  Done

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Alex Gough (Gerrit)

unread,

Jun 23, 2023, 4:32:53 PM6/23/23

to Alex Gough, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

Patch set 5:Code-Review -1

View Change

1 comment:

Patchset:
- Patch Set #5:
  oh wait - got to actually upload the change

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Alex Gough (Gerrit)

unread,

Jun 23, 2023, 4:34:01 PM6/23/23

to Alex Gough, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

Patch set 6:-Code-ReviewCommit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #6:
  ok ptal sorry for the noise

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Mark Mentovai (Gerrit)

unread,

Jun 23, 2023, 4:37:51 PM6/23/23

to Alex Gough, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Alex Gough.

Patch set 6:Code-Review +1

View Change

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Alex Gough (Gerrit)

unread,

Jun 23, 2023, 4:38:57 PM6/23/23

to Alex Gough, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Patch set 6:Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #6:
  thanks - I'll have a think to see about the bots but I'm currently stuck!

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Jun 23, 2023, 4:49:10 PM6/23/23

to Alex Gough, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change

Approvals:
  Mark Mentovai: Looks good to me
  Alex Gough: Commit

SetErrorMode() in fastfail tests

Some versions of python call SetErrorMode which disables
WerFault handling for the fastfail test programs. We can
set this to a useful value, allowing these tests to run
again locally.

This does not enable the tests on the bots as they continue
to fail.

Bug: crashpad:458
Change-Id: Ibdd2f92ed872bd76490db32dccb2257dd91f8280
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4641231
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Alex Gough <aj...@chromium.org>
---
M handler/win/fastfail_test_program.cc
1 file changed, 4 insertions(+), 0 deletions(-)

diff --git a/handler/win/fastfail_test_program.cc b/handler/win/fastfail_test_program.cc
index 510ee56..346aa68 100644
--- a/handler/win/fastfail_test_program.cc
+++ b/handler/win/fastfail_test_program.cc
@@ -129,6 +129,10 @@
     return EXIT_FAILURE;
   }
 
+  // Some versions of python call SetErrorMode() which extends to children, and
+  // prevents the WerFault infrastructure from running.
+  SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX);
+
   if (type == L"cf")
     CfgCrash();
   if (type == L"ff")

To view, visit change 4641231. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward