Fix SIGBUS crash in signal handlers on Linux x86-64 [crashpad/crashpad : main]

1 view

Skip to first unread message

unread,

Jan 14, 2026, 12:44:00 AM (yesterday) Jan 14

to Jared Mauch, Crashpad LUCI CQ, Will Harris, Joshua Peraza, Justin Cohen, crashp...@chromium.org

Attention needed from Jared Mauch, Joshua Peraza and Justin Cohen

Will Harris added 1 comment

Patchset-level comments

Will Harris . unresolved

This likely needs a change to a build file for the include...?

Please file a bug. The bug describes the defect. The CL describes the fix.

When adding multiple overlapping reviewers please be clear which reviewer is reviewing which file.

Finally, I think mpdenton@ might be a better reviewer for this code.

Attention is currently required from:

Submit Requirements:

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

unread,

Jan 14, 2026, 8:50:01 AM (20 hours ago) Jan 14

to Jared Mauch, Crashpad LUCI CQ, Will Harris, Joshua Peraza, Justin Cohen, crashp...@chromium.org

Attention needed from Jared Mauch, Joshua Peraza and Justin Cohen

File util/posix/signals_stack_align.h

Line 48, Patchset 1 (Latest): "test $0x8, %%rsp\n\t"

Mark Mentovai . unresolved

It's possible to write this routine without any branches.

Mark Mentovai . unresolved

When?

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages