Revert "DEPS: fix version of fuchsia/sdk/core to avoid build error" [crashpad/crashpad : main]
4 views
Skip to first unread message
Rubber Stamper (Gerrit)
Jun 5, 2024, 9:55:05 PMJun 5
to Takuto Ikuta, Crashpad LUCI CQ, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jun 5, 2024, 9:55:45 PMJun 5
to Takuto Ikuta, Rubber Stamper, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Takuto Ikuta
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Commit Message
Line 11, Patchset 1:
Reason for revert: WIPMark Mentovai . unresolved
Please write a better pointer to the problem (link to broken build? or does this mean that the previous change was committed accidentally?)
Related details
Attention is currently required from:
- Takuto Ikuta
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jun 5, 2024, 9:57:06 PMJun 5
to Takuto Ikuta, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Takuto Ikuta
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Takuto Ikuta
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takuto Ikuta (Gerrit)
Jun 5, 2024, 11:01:17 PMJun 5
to Takuto Ikuta, Rubber Stamper, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Takuto Ikuta voted and added 1 comment![]( "Open in Gerrit")
Votes added by Takuto Ikuta
| Commit-Queue | +2 |
1 comment
Commit Message
Line 11, Patchset 1:
Reason for revert: WIPMark Mentovai . resolved
Please write a better pointer to the problem (link to broken build? or does this mean that the previous change was committed accidentally?)
Takuto Ikuta
Updated. I think this is not necessary now.
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Jun 5, 2024, 11:01:25 PMJun 5
to Takuto Ikuta, Rubber Stamper, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Revert "DEPS: fix version of fuchsia/sdk/core to avoid build error"
This reverts commit a63adda6278e9caa75361051cb23fd914e533151.
Reason for revert:
This is not necessary after https://crrev.com/c/5585353.
Original change's description:
> DEPS: fix version of fuchsia/sdk/core to avoid build error
>
> This is a temporary workaround to avoid error like
> https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_fuchsia_arm64_dbg/1299/overview
>
> Bug: 41489832
> Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5599904
> Commit-Queue: Takuto Ikuta <tik...@chromium.org>
> Reviewed-by: Mark Mentovai <ma...@chromium.org>
Bug: 41489832
Change-Id: I2c6d3c3008047a6f79fb3bfddd8240a758ee645a
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Takuto Ikuta <tik...@chromium.org>
Files:
- M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages