Convert base::StringPiece to std::string_view [crashpad/crashpad : main]
1 view
Skip to first unread message
Mark Mentovai (Gerrit)
Aug 15, 2025, 4:25:54 PMAug 15
to Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
File tools/tool_support.h
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Aug 15, 2025, 4:48:01 PMAug 15
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Joshua Peraza voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joshua Peraza
| Commit-Queue | +2 |
1 comment
File tools/tool_support.h
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Aug 15, 2025, 4:58:49 PMAug 15
to Joshua Peraza, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/tool_support.h
Insertions: 0, Deletions: 1.
@@ -19,7 +19,6 @@
#include <string_view>
#include "base/files/file_path.h"
-
#include "build/build_config.h"
namespace crashpad {
```
Change information
Commit message:
Convert base::StringPiece to std::string_view
Upstreams https://chromium-review.googlesource.com/c/chromium/src/+/5698665
Bug: 40506050
Change-Id: Idde07d7a8c8bb7209b38543b44fd13be72c9ce12
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Joshua Peraza <jpe...@chromium.org>
Files:
- M DEPS
- M client/annotation.h
- M client/crash_report_database_mac.mm
- M client/ring_buffer_annotation_load_test_main.cc
- M client/simple_string_dictionary.h
- M client/simple_string_dictionary_test.cc
- M snapshot/linux/debug_rendezvous_test.cc
- M snapshot/linux/system_snapshot_linux.cc
- M tools/tool_support.cc
- M tools/tool_support.h
- M util/mac/mac_util.cc
- M util/mac/xattr.cc
- M util/mac/xattr.h
- M util/mach/symbolic_constants_mach.cc
- M util/mach/symbolic_constants_mach.h
- M util/mach/symbolic_constants_mach_test.cc
- M util/misc/lexing.cc
- M util/misc/uuid.cc
- M util/misc/uuid.h
- M util/misc/uuid_test.cc
- M util/posix/symbolic_constants_posix.cc
- M util/posix/symbolic_constants_posix.h
- M util/posix/symbolic_constants_posix_test.cc
Change size: L
Delta: 23 files changed, 161 insertions(+), 159 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages