Fix some accidental uses of argument-dependent lookup [crashpad/crashpad : main]

David Benjamin (Gerrit)

unread,

Feb 28, 2023, 4:34:29 PM2/28/23

to Robert Sesek, crashp...@chromium.org

Attention is currently required from: Robert Sesek.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 4298113. To unsubscribe, or for help writing mail filters, visit settings.

Robert Sesek (Gerrit)

unread,

Feb 28, 2023, 4:35:09 PM2/28/23

to David Benjamin, Robert Sesek, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: David Benjamin.

Patch set 2:Code-Review +1

View Change

To view, visit change 4298113. To unsubscribe, or for help writing mail filters, visit settings.

David Benjamin (Gerrit)

unread,

Feb 28, 2023, 5:02:23 PM2/28/23

to Robert Sesek, Crashpad LUCI CQ, crashp...@chromium.org

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4298113. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Feb 28, 2023, 5:02:32 PM2/28/23

to David Benjamin, Robert Sesek, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change

Approvals:
  Robert Sesek: Looks good to me
  David Benjamin: Commit

Fix some accidental uses of argument-dependent lookup

StringToInt(string_piece) works because base::StringPiece is in
namespace base, but when it is switched to std::string_view, this won't
work anymore. Use the idiomatic spelling.

Bug: chromium:691162
Change-Id: Ic45e0d2729fa5fc7c3e7a56fe159957b1bdcdf94
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4298113
Commit-Queue: David Benjamin <davi...@chromium.org>
Reviewed-by: Robert Sesek <rse...@chromium.org>
---
M client/ring_buffer_annotation_load_test_main.cc
M snapshot/linux/system_snapshot_linux.cc
2 files changed, 8 insertions(+), 8 deletions(-)

To view, visit change 4298113. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward