Fix MemorySnapshotSanitized for 32-bit builds, where size_t ≠ VMAddress [crashpad/crashpad : main]
0 views
Skip to first unread message
Mark Mentovai (Gerrit)
11:33 AM (5 hours ago) 11:33 AM
to Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
11:36 AM (5 hours ago) 11:36 AM
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
11:41 AM (5 hours ago) 11:41 AM
to Joshua Peraza, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
11:51 AM (5 hours ago) 11:51 AM
to Mark Mentovai, Joshua Peraza, crashp...@chromium.org
crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix MemorySnapshotSanitized for 32-bit builds, where size_t ≠ VMAddress
By explicitly requesting the desired specialization of std::min, this
fixes a compile-time error encountered with 526fd4a0352b at
https://ci.chromium.org/ui/p/chromium/builders/try/android-binary-size/2851684/
→ 33. compile → stdout:
../../third_party/crashpad/crashpad/snapshot/sanitized/memory_snapshot_sanitized.cc:60:35: error: no matching function for call to 'min'
60 | const size_t aligned_offset = std::min(
| ^~~~~~~~
../../third_party/libc++/src/include/__algorithm/min.h:35:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('size_t' (aka 'unsigned int') vs. 'VMAddress' (aka 'unsigned long long'))
35 | min(_LIBCPP_LIFETIMEBOUND const _Tp& __a, _LIBCPP_LIFETIMEBOUND const _Tp& __b) {
| ^
../../third_party/libc++/src/include/__algorithm/min.h:43:1: note: candidate template ignored: could not match 'initializer_list<_Tp>' against 'size_t' (aka 'unsigned int')
43 | min(initializer_list<_Tp> __t, _Compare __comp) {
| ^
../../third_party/libc++/src/include/__algorithm/min.h:48:82: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
48 | [[__nodiscard__]] inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 _Tp min(initializer_list<_Tp> __t) {
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/libc++/src/include/__algorithm/min.h:29:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
29 | min(_LIBCPP_LIFETIMEBOUND const _Tp& __a, _LIBCPP_LIFETIMEBOUND const _Tp& __b, _Compare __comp) {
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Bug: 500097298
Change-Id: I782169d71c020cd52c5d4a7c1312364487e44904
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Files:
- M snapshot/sanitized/memory_snapshot_sanitized.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joshua Peraza
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages