mac: 12.0 SDK support [crashpad/crashpad : main]

8 views
Skip to first unread message

Damien DeVille (Gerrit)

unread,
Oct 19, 2021, 7:57:02 PM10/19/21
to crashp...@chromium.org

Attention is currently required from: Robert Sesek, Mark Mentovai.

Damien DeVille uploaded patch set #2 to this change.

View Change

mac: 12.0 SDK support

This patch updates the process_types version of dyld_all_image_infos for
macOS 12.0.

Two new fields were added to the struct, replacing previously `reserved`
space so it required shuffling some things around.

Fixes https://bugs.chromium.org/p/crashpad/issues/detail?id=375

Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
---
M snapshot/mac/process_types_test.cc
M snapshot/mac/process_types/custom.cc
M snapshot/mac/process_types.cc
M snapshot/mac/process_types/dyld_images.proctype
4 files changed, 61 insertions(+), 16 deletions(-)

To view, visit change 3232241. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
Gerrit-Change-Number: 3232241
Gerrit-PatchSet: 2
Gerrit-Owner: Damien DeVille <dd2...@gmail.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Robert Sesek <rse...@chromium.org>
Gerrit-Attention: Robert Sesek <rse...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-MessageType: newpatchset

Damien DeVille (Gerrit)

unread,
Oct 19, 2021, 7:57:03 PM10/19/21
to Robert Sesek, Mark Mentovai, crashp...@chromium.org

Attention is currently required from: Robert Sesek, Mark Mentovai.

Damien DeVille would like Robert Sesek and Mark Mentovai to review this change.

View Change

mac: 12.0 SDK support

This patch updates the process_types version of dyld_all_image_infos for
macOS 12.0.

Two new fields were added to the struct, replacing previously `reserved`
space so it required shuffling some things around.

Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
---
M snapshot/mac/process_types_test.cc
M snapshot/mac/process_types/custom.cc
M snapshot/mac/process_types.cc
M snapshot/mac/process_types/dyld_images.proctype
4 files changed, 59 insertions(+), 16 deletions(-)


To view, visit change 3232241. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
Gerrit-Change-Number: 3232241
Gerrit-PatchSet: 1
Gerrit-Owner: Damien DeVille <dd2...@gmail.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Robert Sesek <rse...@chromium.org>
Gerrit-Attention: Robert Sesek <rse...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-MessageType: newchange

Damien DeVille (Gerrit)

unread,
Oct 19, 2021, 7:57:06 PM10/19/21
to crashp...@chromium.org, Robert Sesek, Mark Mentovai

Attention is currently required from: Robert Sesek, Mark Mentovai.

View Change

    To view, visit change 3232241. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
    Gerrit-Change-Number: 3232241
    Gerrit-PatchSet: 1
    Gerrit-Owner: Damien DeVille <dd2...@gmail.com>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Robert Sesek <rse...@chromium.org>
    Gerrit-Attention: Robert Sesek <rse...@chromium.org>
    Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 Oct 2021 19:30:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Robert Sesek (Gerrit)

    unread,
    Oct 28, 2021, 3:06:47 PM10/28/21
    to Damien DeVille, crashp...@chromium.org, Robert Sesek, Mark Mentovai

    Attention is currently required from: Mark Mentovai.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #2:

        Hi, thanks for the patch!

        Mark and I were chatting about this, and he already had started working on adding macOS 12 support. I’ll defer to his review on this to see if this is similar to what he has done, or if he wants to handle this using his patch.

    To view, visit change 3232241. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
    Gerrit-Change-Number: 3232241
    Gerrit-PatchSet: 2
    Gerrit-Owner: Damien DeVille <dd2...@gmail.com>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Robert Sesek <rse...@chromium.org>
    Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 Oct 2021 19:06:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Robert Sesek (Gerrit)

    unread,
    Nov 19, 2021, 4:24:57 PM11/19/21
    to Damien DeVille, crashp...@chromium.org, Robert Sesek, Mark Mentovai

    Robert Sesek abandoned this change.

    View Change

    Abandoned This was fixed in Chromium and I just upstreamed the patch. This should work now.

    To view, visit change 3232241. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie7a371094e07365d6234cafb6d69f8896efa2849
    Gerrit-Change-Number: 3232241
    Gerrit-PatchSet: 2
    Gerrit-Owner: Damien DeVille <dd2...@gmail.com>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Robert Sesek <rse...@chromium.org>
    Gerrit-MessageType: abandon
    Reply all
    Reply to author
    Forward
    0 new messages