Upgrade linux bots from ubuntu 22 to ubuntu 24 [crashpad/crashpad : main]

8 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Nov 10, 2025, 5:15:46 PMNov 10
to Victor Vianna, Lei Zhang, crashp...@chromium.org
Attention needed from Victor Vianna

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
Gerrit-Change-Number: 7137290
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 22:15:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Will Harris (Gerrit)

unread,
Nov 10, 2025, 5:24:54 PMNov 10
to Victor Vianna, Will Harris, crashp...@chromium.org
Attention needed from Victor Vianna

Will Harris voted and added 1 comment

Votes added by Will Harris

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Will Harris . resolved

seems reasonable, ty for also prepping a revert CL. we should try and revert if anything breaks.

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
Gerrit-Change-Number: 7137290
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 22:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Nov 10, 2025, 5:29:32 PMNov 10
to crashp...@chromium.org

Victor Vianna added 1 comment

File infra/config/generated/cr-buildbucket.cfg
Victor Vianna . unresolved

Keeping this thread open to prevent submission before all deps are ready

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
Gerrit-Change-Number: 7137290
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 21:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Nov 10, 2025, 5:29:32 PMNov 10
to crashp...@chromium.org

Victor Vianna added 1 comment

Patchset-level comments
Victor Vianna . resolved

Oops, sorry Lei, I thought you owned crashpad for some reason

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
Gerrit-Change-Number: 7137290
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 22:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Nov 12, 2025, 8:33:01 PMNov 12
to Crashpad LUCI CQ, Will Harris, crashp...@chromium.org

Victor Vianna voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
Gerrit-Change-Number: 7137290
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 01:32:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Nov 12, 2025, 8:35:30 PMNov 12
to Crashpad LUCI CQ, Will Harris, crashp...@chromium.org

Victor Vianna voted and added 1 comment

Votes added by Victor Vianna

Commit-Queue+2

1 comment

File infra/config/generated/cr-buildbucket.cfg
Victor Vianna . resolved

Keeping this thread open to prevent submission before all deps are ready

Victor Vianna

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
    Gerrit-Change-Number: 7137290
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Will Harris <w...@chromium.org>
    Gerrit-Comment-Date: Thu, 13 Nov 2025 01:35:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Victor Vianna <victor...@google.com>
    satisfied_requirement
    open
    diffy

    Crashpad LUCI CQ (Gerrit)

    unread,
    Nov 12, 2025, 8:35:39 PMNov 12
    to Victor Vianna, Will Harris, crashp...@chromium.org

    Crashpad LUCI CQ submitted the change

    Change information

    Commit message:
    Upgrade linux bots from ubuntu 22 to ubuntu 24
    Bug: 459541007
    Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
    Commit-Queue: Victor Vianna <victor...@google.com>
    Reviewed-by: Will Harris <w...@chromium.org>
    Files:
    • M infra/config/generated/cr-buildbucket.cfg
    • M infra/config/generated/project.cfg
    • M infra/config/main.star
    Change size: S
    Delta: 3 files changed, 15 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Will Harris
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Id4b582947887203a76ecc83e81531b35ad6b0812
    Gerrit-Change-Number: 7137290
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages