Remove workaround for missing std::atomic_thread_fence [chromium/mini_chromium : main]
0 views
Skip to first unread message
Mark Mentovai (Gerrit)
May 15, 2024, 10:12:17 AMMay 15
to weijian pan, crashp...@chromium.org
Attention needed from weijian pan
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Mark Mentovai . resolved
I made some small improvements to the commit message, mostly for accuracy. LGTM.
Related details
Attention is currently required from:
- weijian pan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 15, 2024, 10:13:43 AMMay 15
to weijian pan, crashp...@chromium.org
Attention needed from weijian pan
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mark Mentovai . resolved
I made some small improvements to the commit message, mostly for accuracy. LGTM.
Mark Mentovai
I made some small improvements to the commit message, mostly for accuracy. LGTM.
…but that has rendered me ineligible to review, so, +danakj
Related details
Attention is currently required from:
- weijian pan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 15, 2024, 10:14:12 AMMay 15
to weijian pan, danakj, crashp...@chromium.org
Attention needed from danakj and weijian pan
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Mark Mentovai . resolved
Mark MentovaiI made some small improvements to the commit message, mostly for accuracy. LGTM.
Mark MentovaiI made some small improvements to the commit message, mostly for accuracy. LGTM.
…but that has rendered me ineligible to review, so, +danakj
I made some small improvements to the commit message, mostly for accuracy. LGTM.
…but that has rendered me ineligible to review, so, +danakj
Related details
Attention is currently required from:
- danakj
- weijian pan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
danakj (Gerrit)
May 15, 2024, 11:44:02 AMMay 15
to weijian pan, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai and weijian pan
danakj voted and added 1 comment![]( "Open in Gerrit")
Votes added by danakj
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Mark Mentovai
- weijian pan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 15, 2024, 12:00:06 PMMay 15
to weijian pan, danakj, crashp...@chromium.org
Mark Mentovai submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove workaround for missing std::atomic_thread_fence
Fix compilation error with gcc Linux. std::memory_order is an enum
class, not an enum, which removes implicit conversions in C++20.
Compilers that support C++20 should contain the fix for the libstdc++
bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51038), so removing
the workaround in atomicops_internals_portable.h should be fine.
Bug: 339934812
Change-Id: Ie4f6f4de26b084ff33330db7d87c7881db223a62
Reviewed-by: danakj <dan...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M base/atomicops_internals_portable.h
Change size: XS
Delta: 1 file changed, 0 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by danakj, +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages