Define kMaxValue for Crashpad metrics enums [crashpad/crashpad : main]
14 views
Skip to first unread message
Alexei Svitkine (Gerrit)
Sep 4, 2026, 3:19:51 PMSep 4
to crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, Mark Mentovai, crashp...@chromium.org
Attention needed from Joshua Peraza and Mark Mentovai
Alexei Svitkine added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alexei Svitkine . resolved
Note: Bots are red because https://crrev.com/c/8352510 isn't landed/rolled yet.
Related details
Attention is currently required from:
- Joshua Peraza
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Sep 4, 2026, 3:22:05 PMSep 4
to Alexei Svitkine, crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, crashp...@chromium.org
Attention needed from Alexei Svitkine and Joshua Peraza
Mark Mentovai added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Mark Mentovai . resolved
Please either roll mini_chromium in this change, or roll it in a separate change, rebase this, and resubmit the try jobs.
Commit Message
Line 40, Patchset 5 (Latest):
TAG=agy
CONV=72bbc372-edca-45d3-9d0b-e25b79a10306
Mark Mentovai . unresolved
Move these up above Bug: (with a blank line between) to avoid confusing things looking for a properly formed git footer.
Related details
Attention is currently required from:
- Alexei Svitkine
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Sep 4, 2026, 3:54:08 PMSep 4
to crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, Mark Mentovai, crashp...@chromium.org
Attention needed from Joshua Peraza and Mark Mentovai
Alexei Svitkine added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Mark Mentovai . resolved
Please either roll mini_chromium in this change, or roll it in a separate change, rebase this, and resubmit the try jobs.
Alexei Svitkine
Done.
Commit Message
Move these up above Bug: (with a blank line between) to avoid confusing things looking for a properly formed git footer.
Attention is currently required from:
- Joshua Peraza
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Sep 4, 2026, 4:29:37 PMSep 4
to Alexei Svitkine, crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, crashp...@chromium.org
Attention needed from Alexei Svitkine and Joshua Peraza
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexei Svitkine
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Sep 4, 2026, 4:35:18 PMSep 4
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza
Alexei Svitkine voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Sep 4, 2026, 4:35:30 PMSep 4
to Alexei Svitkine, Mark Mentovai, Joshua Peraza, crashp...@chromium.org
crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Define kMaxValue for Crashpad metrics enums
In Chromium, the standard convention for enum histograms is to
define kMaxValue as the highest valid value in the enum, and
record samples using the 2-argument macro
UMA_HISTOGRAM_ENUMERATION(name, sample), which automatically
deduces the exclusive upper bound.
Chromium is updating UMA_HISTOGRAM_ENUMERATION to disallow
passing kMaxValue as the third argument (crrev.com/c/8329130)
because doing so treats kMaxValue as an exclusive bound,
which drops valid samples.
Previously, Crashpad defined kMaxValue in several metrics enums
as an invalid sentinel value (the exclusive count of values)
and passed it to the 3-argument UMA_HISTOGRAM_ENUMERATION macro.
This change:
1. Rolls mini_chromium to c029983310e7 (crrev.com/c/8352510) to
support 2-argument UMA_HISTOGRAM_ENUMERATION macros in
standalone builds.
2. Updates Crashpad metrics enums (PendingReportReason,
CrashSkippedReason, CaptureResult, LifetimeMilestone, and
ExceptionProcessingState) so kMaxValue is the highest
valid value.
3. Updates UMA_HISTOGRAM_ENUMERATION call sites to use the
2-argument form.
Downstream changes:
- Enables landing Chromium CL (crrev.com/c/8329130) without
breaking Crashpad metrics. A temporary in-tree copy of these
changes is at crrev.com/c/8356797.
TAG=agy
CONV=72bbc372-edca-45d3-9d0b-e25b79a10306
Bug: 545187388
Change-Id: Id40de830662d0029d2e59453506ca8704cd29289
Commit-Queue: Alexei Svitkine <asvi...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M DEPS
- M util/misc/metrics.cc
- M util/misc/metrics.h
Change size: S
Delta: 3 files changed, 16 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages