Add static cast to std::memory_order_seq_cst [chromium/mini_chromium : main]
0 views
Skip to first unread message
weijian pan (Gerrit)
May 10, 2024, 9:46:52 AMMay 10
to Mark Mentovai, crashp...@chromium.org
weijian pan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
weijian pan . resolved
I am trying to fix compilation error with gcc Linux. In atomicops_internals_portable.h Line 57 : __atomic_thread_fence(std::memory_order_seq_cst);
std::memory_order is an enum class, not an enum, which removes implicit conversions in c++20.
Best regards
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 10, 2024, 9:51:16 AMMay 10
to weijian pan, crashp...@chromium.org
Attention needed from weijian pan
Mark Mentovai added 3 comments![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 5 (Latest):
Fix compilation error with gcc Linux. std::memory_order is an enum class, not an enum, which removes implicit conversions in c++20.Mark Mentovai . unresolved
Wrap git commit messages at 72 columns.
Line 11, Patchset 5 (Latest):
Bug: 338911999Mark Mentovai . unresolved
This is not a Chromium or Crashpad bug number.
File base/atomicops_internals_portable.h
Line 55, Patchset 5 (Latest):
// Work around libstdc++ bug 51038 where atomic_thread_fence was declared but
// not defined, leading to the linker complaining about undefined references.Mark Mentovai . unresolved
If your libstdc++ is new enough to have C++20 support, is it also new enough for this bug to be fixed?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51038
It was fixed in 2011. Maybe we don’t need this branch at all any longer.
Related details
Attention is currently required from:
- weijian pan
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages