clang-tidy: concatenate nested namespaces [crashpad/crashpad : main]

5 views
Skip to first unread message

Jesse McKenna (Gerrit)

unread,
Oct 21, 2025, 1:36:22 PMOct 21
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Jesse McKenna added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jesse McKenna . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b5ef3deef40e5850b92a0375b00b057c9b60244
Gerrit-Change-Number: 7068660
Gerrit-PatchSet: 1
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Oct 2025 17:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Oct 21, 2025, 1:52:45 PMOct 21
to Jesse McKenna, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Jesse McKenna and Justin Cohen

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jesse McKenna
  • Justin Cohen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b5ef3deef40e5850b92a0375b00b057c9b60244
Gerrit-Change-Number: 7068660
Gerrit-PatchSet: 1
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Jesse McKenna <jessem...@google.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 17:52:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jesse McKenna (Gerrit)

unread,
Oct 21, 2025, 6:41:06 PMOct 21
to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Jesse McKenna voted and added 1 comment

Votes added by Jesse McKenna

Commit-Queue+2

1 comment

Patchset-level comments
Jesse McKenna . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b5ef3deef40e5850b92a0375b00b057c9b60244
Gerrit-Change-Number: 7068660
Gerrit-PatchSet: 1
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Oct 2025 22:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Oct 21, 2025, 6:41:17 PMOct 21
to Jesse McKenna, Mark Mentovai, Justin Cohen, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
clang-tidy: concatenate nested namespaces

This fixes the following clang-tidy error seen when rolling Crashpad
into Chrome:

check: modernize-concat-nested-namespaces

nested namespaces can be concatenated
(https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html)
Change-Id: I5b5ef3deef40e5850b92a0375b00b057c9b60244
Commit-Queue: Jesse McKenna <jessem...@google.com>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M handler/crash_report_upload_rate_limit_test.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b5ef3deef40e5850b92a0375b00b057c9b60244
Gerrit-Change-Number: 7068660
Gerrit-PatchSet: 2
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages