Add test filter upstream in Crashpad [crashpad/crashpad : main]
Avi Drissman (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Mark Mentovai
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
- Avi Drissman
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman voted Commit-Queue+2![]( "Open in Gerrit")
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Add test filter upstream in Crashpad
https://crrev.com/c/2765630 added a test filter to Crashpad downstream
in Chromium, but it was never upstreamed into the Crashpad repo.
Do so now.
- M BUILD.gn
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
Thomas Gales added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Should this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
Related details
- Avi Drissman
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Should this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
This is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
Thomas Gales added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Avi DrissmanShould this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
This is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
I think it builds in Chromium because Chromium supplies the target [1]. I'm not sure what it's for, but if I _**had**_ to guess Fuchsia doesn't seem to need it?
Do Crashpad changes not automatically roll downstream to Chromium?
Related details
- Avi Drissman
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Avi DrissmanShould this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
Thomas GalesThis is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
I think it builds in Chromium because Chromium supplies the target [1]. I'm not sure what it's for, but if I _**had**_ to guess Fuchsia doesn't seem to need it?
Do Crashpad changes not automatically roll downstream to Chromium?
Do Crashpad changes not automatically roll downstream to Chromium?
Alas, Crashpad is weird. This repo is the canonical repo, but synchronization to the downstream is a manual process and sometimes stuff ends up downstream that doesn’t make it upstream for years.
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Avi DrissmanShould this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
Thomas GalesThis is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
Avi DrissmanI think it builds in Chromium because Chromium supplies the target [1]. I'm not sure what it's for, but if I _**had**_ to guess Fuchsia doesn't seem to need it?
Do Crashpad changes not automatically roll downstream to Chromium?
Do Crashpad changes not automatically roll downstream to Chromium?
Alas, Crashpad is weird. This repo is the canonical repo, but synchronization to the downstream is a manual process and sometimes stuff ends up downstream that doesn’t make it upstream for years.
Yeah, this should be in `crashpad_is_in_chromium`. I didn’t catch the `|| crashpad_is_in_fuchsia` yesterday. Sorry.
Related details
- Avi Drissman
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Avi DrissmanShould this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
Thomas GalesThis is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
Avi DrissmanI think it builds in Chromium because Chromium supplies the target [1]. I'm not sure what it's for, but if I _**had**_ to guess Fuchsia doesn't seem to need it?
Do Crashpad changes not automatically roll downstream to Chromium?
Mark MentovaiDo Crashpad changes not automatically roll downstream to Chromium?
Alas, Crashpad is weird. This repo is the canonical repo, but synchronization to the downstream is a manual process and sometimes stuff ends up downstream that doesn’t make it upstream for years.
Yeah, this should be in `crashpad_is_in_chromium`. I didn’t catch the `|| crashpad_is_in_fuchsia` yesterday. Sorry.
OK, so if you make the change here, I’ll include it in the roll that I do into the Chromium repo in the next few days.
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
Thomas Gales added 1 comment![]( "Open in Gerrit")
data_deps = [ "//testing/buildbot/filters:crashpad_tests_filters" ]Avi DrissmanShould this dependency have been upstreamed? AFAICT, this target doesn't exist in Crashpad.
This broke Fuchsia's roller (https://fxrev.dev/1287609), and I'm happy to wrap this in a `if(!crashpad_is_in_fuchsia)`, but thought I'd check first to make sure the build target shouldn't be upstreamed instead.
Thomas GalesThis is supposed to match what’s in Chromium, and it does (see [Chromium’s copy](https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/BUILD.gn;drc=ee252bede74f28790d16620fa574fea29e34f169;l=37)).
How does this build in Chromium? It might make sense to wrap this with “if not fuchsia” but then we’d want to roll that change downstream to Chromium.
Avi DrissmanI think it builds in Chromium because Chromium supplies the target [1]. I'm not sure what it's for, but if I _**had**_ to guess Fuchsia doesn't seem to need it?
Do Crashpad changes not automatically roll downstream to Chromium?
Mark MentovaiDo Crashpad changes not automatically roll downstream to Chromium?
Alas, Crashpad is weird. This repo is the canonical repo, but synchronization to the downstream is a manual process and sometimes stuff ends up downstream that doesn’t make it upstream for years.
Avi DrissmanYeah, this should be in `crashpad_is_in_chromium`. I didn’t catch the `|| crashpad_is_in_fuchsia` yesterday. Sorry.
OK, so if you make the change here, I’ll include it in the roll that I do into the Chromium repo in the next few days.
Uploaded [1] for this
[1] https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6602453
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |