util: Simplify MacOSVersionNumber [crashpad/crashpad : main]
1 view
Skip to first unread message
Mark Mentovai (Gerrit)
Jul 29, 2025, 10:58:52 AMJul 29
to Justin Cohen, Christine Hollingsworth, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mark Mentovai . resolved
Justin for review. (I checked but don’t see similar code in use on iOS.)
Christine for exposure.
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Jul 29, 2025, 3:19:20 PMJul 29
to Mark Mentovai, Crashpad LUCI CQ, Christine Hollingsworth, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Justin Cohen
| Code-Review | +1 |
1 comment
Patchset-level comments
Mark Mentovai . resolved
Justin for review. (I checked but don’t see similar code in use on iOS.)
Christine for exposure.
Justin Cohen
iOS uses [[NSProcessInfo processInfo] operatingSystemVersion] in util/ios/ios_system_data_collector.mm to get the same information.
LGTM
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 30, 2025, 10:37:49 AMJul 30
to Justin Cohen, Crashpad LUCI CQ, Christine Hollingsworth, crashp...@chromium.org
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Jul 30, 2025, 10:38:00 AMJul 30
to Mark Mentovai, Justin Cohen, Christine Hollingsworth, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
util: Simplify MacOSVersionNumber
sysctlbyname("kern.osproductversion", …) is available since macOS
10.13.4, which is now well below this code’s minimum runtime OS version.
The old implementation that fell back to calling uname and inferring the
macOS version from utsname::release is no longer necessary.
Tests and documentation are also slightly updated and improved.
Test: crashpad_util_test MacUtil.MacOSVersion*
Change-Id: Idb26bb59c124ab2191ef961f01e9691856f2c812
Reviewed-by: Justin Cohen <justi...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Files:
- M util/mac/mac_util.cc
- M util/mac/mac_util.h
- M util/mac/mac_util_test.mm
Change size: M
Delta: 3 files changed, 53 insertions(+), 110 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages