base: Switch to Fuchsia's SDK logging API [chromium/mini_chromium : main]
10 views
Skip to first unread message
Chris Suter (Gerrit)
Jul 23, 2025, 9:59:53 AMJul 23
to Christopher Johnson, Justin Cohen, crashp...@chromium.org
Attention needed from Justin Cohen
Chris Suter added 1 comment![]( "Open in Gerrit")
File base/BUILD.gn
Line 160, Patchset 2 (Latest):
deps = [ "//third_party/fuchsia/sdk/$host_os-amd64/pkg/syslog_cpp" ]Chris Suter . unresolved
I'm not sure how to test this change. I'm hoping someone can run some pre-submits for me on this.
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2025, 7:18:22 AMJul 24
to Chris Suter, Christopher Johnson, Justin Cohen, crashp...@chromium.org
Attention needed from Chris Suter and Justin Cohen
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Chris Suter
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Jul 24, 2025, 1:43:22 PMJul 24
to Chris Suter, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Attention needed from Chris Suter
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Chris Suter
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Suter (Gerrit)
Jul 24, 2025, 5:49:18 PMJul 24
to Justin Cohen, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Chris Suter added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Chris Suter . unresolved
Please could someone run the try jobs for me.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2025, 7:03:34 PMJul 24
to Chris Suter, Justin Cohen, Christopher Johnson, crashp...@chromium.org
Attention needed from Chris Suter
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Chris Suter . resolved
Please could someone run the try jobs for me.
Mark Mentovai
Please could someone run the try jobs for me.
Attention is currently required from:
- Chris Suter
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2025, 7:06:55 PMJul 24
to Chris Suter, Justin Cohen, Christopher Johnson, crashp...@chromium.org
Attention needed from Chris Suter
Mark Mentovai added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Chris Suter . resolved
Mark MentovaiPlease could someone run the try jobs for me.
Mark MentovaiPlease could someone run the try jobs for me.
No trybots for mini_chromium.
Please could someone run the try jobs for me.
No trybots for mini_chromium.
You can propose a Crashpad change rolling mini_chromium in it's DEPS to the hash of this patch set, and test on the Crashpad bots.
Commit Message
Line 7, Patchset 2 (Latest):
base: Switch to Fuchsia's SDK logging APIMark Mentovai . unresolved
mini_chromium is only base, so you don't need to say "base:"
Related details
Attention is currently required from:
- Chris Suter
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Suter (Gerrit)
Jul 24, 2025, 8:38:26 PMJul 24
to Justin Cohen, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Chris Suter added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Chris Suter . resolved
Mark MentovaiPlease could someone run the try jobs for me.
Mark MentovaiPlease could someone run the try jobs for me.
No trybots for mini_chromium.
Please could someone run the try jobs for me.
No trybots for mini_chromium.
You can propose a Crashpad change rolling mini_chromium in it's DEPS to the hash of this patch set, and test on the Crashpad bots.
Chris Suter
Done: https://crrev.com/c/6786247.
File-level comment, Patchset 4 (Latest):
Chris Suter . resolved
I had to fix something. Tests appear to be passing now (see https://crrev.com/c/6786247). Please could I get +1 again.
Commit Message
mini_chromium is only base, so you don't need to say "base:"
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Suter (Gerrit)
Jul 24, 2025, 8:39:09 PMJul 24
to Justin Cohen, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Chris Suter added 1 comment![]( "Open in Gerrit")
File base/BUILD.gn
Line 160, Patchset 2:
deps = [ "//third_party/fuchsia/sdk/$host_os-amd64/pkg/syslog_cpp" ]Chris Suter . resolved
Chris SuterI'm not sure how to test this change. I'm hoping someone can run some pre-submits for me on this.
Acknowledged
Related details
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2025, 10:12:42 PMJul 24
to Chris Suter, Justin Cohen, Christopher Johnson, crashp...@chromium.org
Attention needed from Chris Suter and Justin Cohen
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Chris Suter
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Jul 28, 2025, 7:15:51 PMJul 28
to Chris Suter, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Attention needed from Chris Suter
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Chris Suter
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Jul 28, 2025, 7:16:59 PMJul 28
to Chris Suter, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Justin Cohen submitted the change![]( "Open in Gerrit")
Change information
Commit message:
base: Switch to Fuchsia's SDK logging API
Change-Id: If70af644c5eab01001621193d2ea32a12b2dd059
Reviewed-by: Justin Cohen <justi...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M base/BUILD.gn
- M base/logging.cc
Change size: S
Delta: 2 files changed, 17 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen, +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 28, 2025, 7:23:27 PMJul 28
to Chris Suter, Justin Cohen, Christopher Johnson, crashp...@chromium.org
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2:
base: Switch to Fuchsia's SDK logging APIMark Mentovai . resolved
Chris Sutermini_chromium is only base, so you don't need to say "base:"
Done
Mark Mentovai
Done
This was submitted without ever actually being resolved.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Suter (Gerrit)
Jul 28, 2025, 7:35:02 PMJul 28
to Justin Cohen, Mark Mentovai, Christopher Johnson, crashp...@chromium.org
Chris Suter added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2:
base: Switch to Fuchsia's SDK logging APIMark Mentovai . resolved
Chris Sutermini_chromium is only base, so you don't need to say "base:"
Mark MentovaiDone
Done
This was submitted without ever actually being resolved.
Chris Suter
Sorry, I did fix this, but I lost the fix between PS3 and PS5.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages