crashpad: fix nullptr reference in CleanDatabase() [crashpad/crashpad : main]

5 views

Skip to first unread message

Sorin Jianu (Gerrit)

unread,

Nov 12, 2025, 6:24:03 PMNov 12

to Mark Mentovai, crashp...@chromium.org

Attention needed from Mark Mentovai

Sorin Jianu added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Sorin Jianu . resolved

Mark, PTAL, thank you!

The code crashes when Omaha is tearing down at `removed += metadata->CleanDatabase();` because the `metadata` is nullptr.
```
0:003> dv
           this = 0x00000000`00000000
```
```
`0:003> kc
  *** Stack trace for last set context - .thread/.cxr resets it
 # Call Site
00 updater!std::__Cr::vector<crashpad::(anonymous namespace)::ReportDisk,std::__Cr::allocator<crashpad::(anonymous namespace)::ReportDisk> >::begin
01 updater!crashpad::`anonymous namespace'::Metadata::CleanDatabase
02 updater!crashpad::CrashReportDatabaseWin::CleanDatabase
03 updater!crashpad::PruneCrashReportThread::DoWork
04 updater!crashpad::internal::WorkerThreadImpl::ThreadMain
05 updater!crashpad::Thread::ThreadEntryThunk
06 kernel32!BaseThreadInitThunk
07 ntdll!RtlUserThreadStart
```

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Mark Mentovai (Gerrit)

unread,

Nov 12, 2025, 10:18:58 PMNov 12

to Sorin Jianu, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Sorin Jianu

Mark Mentovai voted and added 2 comments

Votes added by Mark Mentovai

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Mark Mentovai . resolved

LGTM otherwise

Commit Message

Line 7, Patchset 1 (Latest):crashpad: fix nullptr reference in CleanDatabase()

Mark Mentovai . unresolved

In the Crashpad repository, a “crashpad:” prefix doesn’t make any sense.

The crash affects only the Windows database, so you could write “win:” or nothing at all.

Open in Gerrit

Related details

Attention is currently required from:

Sorin Jianu

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages