Fix another argument-dependent-lookup dependency [crashpad/crashpad : main]

David Benjamin (Gerrit)

unread,

Mar 15, 2023, 1:02:24 AM3/15/23

to Robert Sesek, crashp...@chromium.org

Attention is currently required from: Robert Sesek.

Patch set 1:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  Oops, forgot to send this out for review!

To view, visit change 4297482. To unsubscribe, or for help writing mail filters, visit settings.

Robert Sesek (Gerrit)

unread,

Mar 15, 2023, 8:36:41 AM3/15/23

to David Benjamin, Robert Sesek, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: David Benjamin.

Patch set 1:Code-Review +1

View Change

To view, visit change 4297482. To unsubscribe, or for help writing mail filters, visit settings.

David Benjamin (Gerrit)

unread,

Mar 15, 2023, 12:54:46 PM3/15/23

to Robert Sesek, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: David Benjamin.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 4297482. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Mar 15, 2023, 12:54:55 PM3/15/23

to David Benjamin, Robert Sesek, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change

Approvals:
  Robert Sesek: Looks good to me
  David Benjamin: Commit

Fix another argument-dependent-lookup dependency

Missed this the first time around because it was Windows-only.

Bug: chromium:691162
Change-Id: Ic98a5943957f77fbf17d92a93409eaa35910ae0e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4297482
Commit-Queue: David Benjamin <davi...@chromium.org>
Reviewed-by: Robert Sesek <rse...@chromium.org>
---
M util/misc/uuid.cc
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/misc/uuid.cc b/util/misc/uuid.cc
index 3c4bd48..a3c33f4 100644
--- a/util/misc/uuid.cc
+++ b/util/misc/uuid.cc
@@ -90,7 +90,7 @@
 
 #if BUILDFLAG(IS_WIN)
 bool UUID::InitializeFromString(const base::WStringPiece& string) {
-  return InitializeFromString(WideToUTF8(string));
+  return InitializeFromString(base::WideToUTF8(string));
 }
 #endif

To view, visit change 4297482. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward