Attention is currently required from: Mark Mentovai.
Patch set 1:Commit-Queue +1
1 comment:
Patchset:
This does not compile in Chromium -- I guess base::StringPiece doesn't have as_string().
To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Justin Cohen.
1 comment:
File client/ring_buffer_annotation_load_test_main.cc:
Patch Set #1, Line 319: fprintf(stderr, "Couldn't parse value: [%s]\n", str.data());
A StringPiece might not be NUL-terminated, so this won’t fly.
To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Mark Mentovai.
2 comments:
Patchset:
Good catch, thank you.
File client/ring_buffer_annotation_load_test_main.cc:
Patch Set #1, Line 319: fprintf(stderr, "Couldn't parse value: [%s]\n", str.data());
A StringPiece might not be NUL-terminated, so this won’t fly.
Done
To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Justin Cohen.
Patch set 2:Code-Review +1
Attention is currently required from: Justin Cohen.
Patch set 2:Commit-Queue +2
Crashpad LUCI CQ submitted this change.
Fix StringPiece compile issue in Chromium.
Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4262547
Commit-Queue: Justin Cohen <justi...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
---
M client/ring_buffer_annotation_load_test_main.cc
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/client/ring_buffer_annotation_load_test_main.cc b/client/ring_buffer_annotation_load_test_main.cc
index 12355f4..96ed25e 100644
--- a/client/ring_buffer_annotation_load_test_main.cc
+++ b/client/ring_buffer_annotation_load_test_main.cc
@@ -316,8 +316,10 @@
base::StringPiece str(reinterpret_cast<const char*>(&bytes[0]),
bytes.size());
if (!HexStringToInt(str, &next_value)) {
- fprintf(
- stderr, "Couldn't parse value: [%s]\n", str.as_string().c_str());
+ fprintf(stderr,
+ "Couldn't parse value: [%.*s]\n",
+ base::checked_cast<int>(bytes.size()),
+ bytes.data());
abort();
}
if (value == std::numeric_limits<int>::max()) {
To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 3:Code-Review +1
1 comment:
Patchset:
Thanks for the fix!
To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.