Fix StringPiece compile issue in Chromium. [crashpad/crashpad : main]

2 views
Skip to first unread message

Justin Cohen (Gerrit)

unread,
Feb 16, 2023, 2:01:07 PM2/16/23
to Mark Mentovai, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

Patch set 1:Commit-Queue +1

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      This does not compile in Chromium -- I guess base::StringPiece doesn't have as_string().

To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
Gerrit-Change-Number: 4262547
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Feb 2023 19:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Mark Mentovai (Gerrit)

unread,
Feb 16, 2023, 2:15:54 PM2/16/23
to Justin Cohen, Ben Hamilton, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Justin Cohen.

View Change

1 comment:

  • File client/ring_buffer_annotation_load_test_main.cc:

    • Patch Set #1, Line 319: fprintf(stderr, "Couldn't parse value: [%s]\n", str.data());

      A StringPiece might not be NUL-terminated, so this won’t fly.

To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
Gerrit-Change-Number: 4262547
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Ben Hamilton <benha...@google.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Feb 2023 19:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Justin Cohen (Gerrit)

unread,
Feb 16, 2023, 3:00:21 PM2/16/23
to Ben Hamilton, Crashpad LUCI CQ, Mark Mentovai, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

View Change

2 comments:

  • Patchset:

  • File client/ring_buffer_annotation_load_test_main.cc:

    • Patch Set #1, Line 319: fprintf(stderr, "Couldn't parse value: [%s]\n", str.data());

      A StringPiece might not be NUL-terminated, so this won’t fly.

    • Done

To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
Gerrit-Change-Number: 4262547
Gerrit-PatchSet: 2
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Ben Hamilton <benha...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Feb 2023 20:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
Gerrit-MessageType: comment

Mark Mentovai (Gerrit)

unread,
Feb 16, 2023, 3:03:32 PM2/16/23
to Justin Cohen, Ben Hamilton, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Justin Cohen.

Patch set 2:Code-Review +1

View Change

    To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
    Gerrit-Change-Number: 4262547
    Gerrit-PatchSet: 2
    Gerrit-Owner: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-CC: Ben Hamilton <benha...@google.com>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Comment-Date: Thu, 16 Feb 2023 20:03:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Justin Cohen (Gerrit)

    unread,
    Feb 16, 2023, 3:06:35 PM2/16/23
    to Mark Mentovai, Ben Hamilton, Crashpad LUCI CQ, crashp...@chromium.org

    Attention is currently required from: Justin Cohen.

    Patch set 2:Commit-Queue +2

    View Change

      To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: main
      Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
      Gerrit-Change-Number: 4262547
      Gerrit-PatchSet: 2
      Gerrit-Owner: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
      Gerrit-CC: Ben Hamilton <benha...@google.com>
      Gerrit-Attention: Justin Cohen <justi...@chromium.org>
      Gerrit-Comment-Date: Thu, 16 Feb 2023 20:06:33 +0000

      Crashpad LUCI CQ (Gerrit)

      unread,
      Feb 16, 2023, 3:19:14 PM2/16/23
      to Justin Cohen, Mark Mentovai, Ben Hamilton, crashp...@chromium.org

      Crashpad LUCI CQ submitted this change.

      View Change

      Approvals: Mark Mentovai: Looks good to me Justin Cohen: Commit
      Fix StringPiece compile issue in Chromium.

      Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
      Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4262547
      Commit-Queue: Justin Cohen <justi...@chromium.org>
      Reviewed-by: Mark Mentovai <ma...@chromium.org>
      ---
      M client/ring_buffer_annotation_load_test_main.cc
      1 file changed, 16 insertions(+), 2 deletions(-)

      diff --git a/client/ring_buffer_annotation_load_test_main.cc b/client/ring_buffer_annotation_load_test_main.cc
      index 12355f4..96ed25e 100644
      --- a/client/ring_buffer_annotation_load_test_main.cc
      +++ b/client/ring_buffer_annotation_load_test_main.cc
      @@ -316,8 +316,10 @@
      base::StringPiece str(reinterpret_cast<const char*>(&bytes[0]),
      bytes.size());
      if (!HexStringToInt(str, &next_value)) {
      - fprintf(
      - stderr, "Couldn't parse value: [%s]\n", str.as_string().c_str());
      + fprintf(stderr,
      + "Couldn't parse value: [%.*s]\n",
      + base::checked_cast<int>(bytes.size()),
      + bytes.data());
      abort();
      }
      if (value == std::numeric_limits<int>::max()) {

      To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: main
      Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
      Gerrit-Change-Number: 4262547
      Gerrit-PatchSet: 3
      Gerrit-Owner: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
      Gerrit-CC: Ben Hamilton <benha...@google.com>
      Gerrit-MessageType: merged

      Ben Hamilton (Gerrit)

      unread,
      Feb 16, 2023, 3:23:20 PM2/16/23
      to Crashpad LUCI CQ, Justin Cohen, Mark Mentovai, crashp...@chromium.org

      Patch set 3:Code-Review +1

      View Change

      1 comment:

      To view, visit change 4262547. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: main
      Gerrit-Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
      Gerrit-Change-Number: 4262547
      Gerrit-PatchSet: 3
      Gerrit-Owner: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Ben Hamilton <benha...@google.com>
      Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
      Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
      Gerrit-Comment-Date: Thu, 16 Feb 2023 20:23:17 +0000
      Reply all
      Reply to author
      Forward
      0 new messages