Raise extra-memory cap in ProcessSnapshotTest.CrashpadInfoChild [crashpad/crashpad : main]

Bruce Dawson (Gerrit)

unread,

Mar 17, 2023, 7:03:44 PM3/17/23

to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

View Change

To view, visit change 4348802. To unsubscribe, or for help writing mail filters, visit settings.

Mark Mentovai (Gerrit)

unread,

Mar 17, 2023, 7:04:38 PM3/17/23

to Bruce Dawson, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Bruce Dawson.

Patch set 2:Code-Review +1

View Change

To view, visit change 4348802. To unsubscribe, or for help writing mail filters, visit settings.

Bruce Dawson (Gerrit)

unread,

Mar 17, 2023, 7:05:50 PM3/17/23

to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Bruce Dawson.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4348802. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Mar 17, 2023, 7:05:59 PM3/17/23

to Bruce Dawson, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change

Approvals:
  Bruce Dawson: Commit
  Mark Mentovai: Looks good to me

Raise extra-memory cap in ProcessSnapshotTest.CrashpadInfoChild

The extra_memory cap in ProcessSnapshotTest.CrashpadInfoChild is not
high enough to avoid test failures on all machines. The actual amount
recorded has been seen to vary between 726,556 and 1,152,803. This
change rases the limit from 1,000,000 to 1,200,000 to avoid the
failures.

The highest amount was seen on a 64-GB gWindows ThinkPad laptop.

Instrumentation shows that the low and high cases both have 104 threads.
The low case has 304 ExtraMemory() blocks, whereas the high case has
409. In both cases the sizes range from 384 to 6,024.

Change-Id: I8873921fa913c31445384db34d4aa90200401a4a
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4348802
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Bruce Dawson <bruce...@chromium.org>
---
M snapshot/win/process_snapshot_win_test.cc
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/snapshot/win/process_snapshot_win_test.cc b/snapshot/win/process_snapshot_win_test.cc
index 5e22498..1bc56ed 100644
--- a/snapshot/win/process_snapshot_win_test.cc
+++ b/snapshot/win/process_snapshot_win_test.cc
@@ -100,10 +100,10 @@
       }
     }
 
-    // Confirm that less than 1M of extra data was gathered. The cap is set to
+    // Confirm that less than 1.2M of extra data was gathered. The cap is set to
     // only 100K, but there are other "extra memory" regions that aren't
     // included in the cap. (Completely uncapped it would be > 10M.)
-    EXPECT_LT(extra_memory_total, 1000000u);
+    EXPECT_LT(extra_memory_total, 1200000u);
   }
 
   // Tell the child it can terminate.

To view, visit change 4348802. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward