Pull latest Fuchsia toolchain [crashpad/crashpad : main]

1 view
Skip to first unread message

Arthur Wang (Gerrit)

unread,
May 10, 2024, 1:02:05 PMMay 10
to Crashpad LUCI CQ, Mark Mentovai, Thomas Gales, crashp...@chromium.org
Attention needed from Mark Mentovai

Arthur Wang added 2 comments

Commit Message
Line 7, Patchset 2:pull latest fuchsia toolchain
Mark Mentovai . resolved

The commit message should use proper capitalization: start with a capital letter, capitalize proper names like Fuchsia.

Arthur Wang

Done

Line 9, Patchset 2:Bug: crashpad:326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694
Mark Mentovai . resolved

These bugs don’t have anything to do with this. Remove this line.

Arthur Wang

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
Gerrit-Change-Number: 5532142
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 10 May 2024 17:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 10, 2024, 1:16:53 PMMay 10
to Arthur Wang, Crashpad LUCI CQ, Thomas Gales, crashp...@chromium.org
Attention needed from Arthur Wang

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Wang
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
Gerrit-Change-Number: 5532142
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Arthur Wang <wuw...@chromium.org>
Gerrit-Comment-Date: Fri, 10 May 2024 17:16:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Wang (Gerrit)

unread,
May 10, 2024, 1:17:02 PMMay 10
to Mark Mentovai, Crashpad LUCI CQ, Thomas Gales, crashp...@chromium.org

Arthur Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
Gerrit-Change-Number: 5532142
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Fri, 10 May 2024 17:16:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 10, 2024, 2:19:24 PMMay 10
to Arthur Wang, Mark Mentovai, Thomas Gales, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Pull latest Fuchsia toolchain
Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
Commit-Queue: Arthur Wang <wuw...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
Gerrit-Change-Number: 5532142
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages