Update cpp-httplib to eacc1ca98e5f (0.27.0) [crashpad/crashpad : main]

0 views

Skip to first unread message

Mark Mentovai (Gerrit)

unread,

Jan 14, 2026, 5:35:08 PM (12 hours ago) Jan 14

to Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza

Mark Mentovai added 1 comment

File third_party/cpp-httplib/cpp-httplib/httplib.h

Line 186, Patchset 3 (Parent):using ssize_t = long;

Mark Mentovai . unresolved

We had local modifications to preserve the ability to target win-x86 (32-bit). This may have been one of them.

Did you preserve all local modifications?

I like to use intermediate patch sets on Gerrit to show the process of applying local modifications, so you can look at the code review from last time I updated this to see what, exactly, the local modifications were in code (as opposed to README) terms. I also encourage you to do the same, which will make for an easier review and provide better change tracking for the next time we need to update this.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages