Update cpp-httplib to eacc1ca98e5f (0.27.0) [crashpad/crashpad : main]
Mark Mentovai (Gerrit)
Mark Mentovai added 1 comment![]( "Open in Gerrit")
using ssize_t = long;We had local modifications to preserve the ability to target win-x86 (32-bit). This may have been one of them.
Did you preserve all local modifications?
I like to use intermediate patch sets on Gerrit to show the process of applying local modifications, so you can look at the code review from last time I updated this to see what, exactly, the local modifications were in code (as opposed to README) terms. I also encourage you to do the same, which will make for an easier review and provide better change tracking for the next time we need to update this.
Related details
- Joshua Peraza
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Joshua Peraza added 1 comment![]( "Open in Gerrit")
using ssize_t = long;We had local modifications to preserve the ability to target win-x86 (32-bit). This may have been one of them.
Did you preserve all local modifications?
I like to use intermediate patch sets on Gerrit to show the process of applying local modifications, so you can look at the code review from last time I updated this to see what, exactly, the local modifications were in code (as opposed to README) terms. I also encourage you to do the same, which will make for an easier review and provide better change tracking for the next time we need to update this.
That was helpful, thanks!
Done in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7489711
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Joshua Peraza voted Commit-Queue+1![]( "Open in Gerrit")
- Joshua Peraza
- Mark Mentovai
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
2 comments
LGTM. Thanks for breaking it down into steps!
- dffce89514c2 Fix 32-bit MSVC compiler error due to unknown command #warning (#2202)Stay within 80 columns (see line 23).
Related details
- Joshua Peraza
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai added 1 comment![]( "Open in Gerrit")
using ssize_t = long;Joshua PerazaWe had local modifications to preserve the ability to target win-x86 (32-bit). This may have been one of them.
Did you preserve all local modifications?
I like to use intermediate patch sets on Gerrit to show the process of applying local modifications, so you can look at the code review from last time I updated this to see what, exactly, the local modifications were in code (as opposed to README) terms. I also encourage you to do the same, which will make for an easier review and provide better change tracking for the next time we need to update this.
That was helpful, thanks!
Done in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7489711
That was helpful, thanks!
Done in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7489711
Let’s go with that one, then!
Related details
- Joshua Peraza
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Joshua Peraza voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joshua Peraza
| Commit-Queue | +2 |
1 comment
- dffce89514c2 Fix 32-bit MSVC compiler error due to unknown command #warning (#2202)Stay within 80 columns (see line 23).
Done
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Joshua Peraza submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/cpp-httplib/README.crashpad
Insertions: 2, Deletions: 1.
@@ -23,4 +23,5 @@
except 32-bit Windows
- 0b3758ec36be Fix problem with Windows version check
- fbee136dca54 Fix #2193. Allow _WIN32
- - dffce89514c2 Fix 32-bit MSVC compiler error due to unknown command #warning (#2202)
+ - dffce89514c2 Fix 32-bit MSVC compiler error due to unknown command
+ #warning (#2202)
```
Change information
Update cpp-httplib to eacc1ca98e5f (0.27.0)
eacc1ca98e5f (HEAD, tag: v0.27.0) Release v0.27.0
ac9ebb0ee333 Merge commit from fork
11eed05ce71b Fix #2255 and #2256
f3bba0646aad Fix benchmark test issue on Windows (#2258)
2da189f88cb0 Fix EventDispatcher problem (#2257)
6e0f211cffc4 Fix problem with .gitignore for examples
318a3fe425c7 Fix problem with installing OpenSSL for Windows (#2254)
2d8d5241783c Fix #2251
afa88dbe70da Fix #2250
08133b593ba6 Merge branch 'staticlibs-ssl_error_reporting'
8aedbf4547b4 Add a unit test
cde29362ef70 Merge branch 'ssl_error_reporting' of github.com:staticlibs/cpp-httplib into staticlibs-ssl_error_reporting
bae40fcdf29f Resolve #2237
db561f5552cf [cmake] FindBrotli: do not add `Brotli::` targets if they already exist (#2249)
35c52c1ab9b8 build(meson): use C++17 for gtest >= 1.17.0 (#2241)
23ff9a56055b Fix error reporting in SSLClient
41be1e24e3a5 Code cleanup
6e52d0a0574d Fix UB by use of dangling references in getaddrinfo_with_timeout (#2232)
f72b4582e600 Fix: Fix Windows Cross-Compilation (#2234)
89c932f313c6 (tag: v0.26.0) Release v0.26.0
eb5a65e0dfba Fix #2217
7a3b92bbd993 Fix: handle EAI_ALLDONE from gai_suspend in getaddrinfo_with_timeout (#2228)
eb11032797f1 Fix platform problem
54e75dc8ef4d Add manual run
b20b5fdd1f53 Add 'release-docker' workflow
f4cc542d4b51 Fix Dockerfile problem with CMD
4285d33992bf Fix #2223 (#2224)
92b4f5301239 clang-format
b8e21eac89a9 Initialize start time for server (#2220)
3fae5f1473fb osx: fix inconsistent use of the macro TARGET_OS_OSX (#2222)
fe7fe15d2ea9 build(meson): fix new build option names (#2208)
fbd6ce7a3f98 Make code sample compilable (#2207)
dffce89514c2 #2201 Fix 32-bit MSVC compiler error due to unknown command #warning (#2202)
- M third_party/cpp-httplib/README.crashpad
- M third_party/cpp-httplib/cpp-httplib/README.md
- M third_party/cpp-httplib/cpp-httplib/httplib.h
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |