infra: Move crashpad ci/try builds from Ubuntu-18.04 to Ubuntu-22.04 [crashpad/crashpad : main]
Ben Pastene (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Mark Mentovai
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
- Ben Pastene
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
infra: Move crashpad ci/try builds from Ubuntu-18.04 to Ubuntu-22.04
These are the last remaining jobs on the last remaining bionic pools.
Moving these over should let the bionic flex pool finally be decommed.
All of chrome/chromium has been on Ubuntu-22.04 for months now. So
hopefully this is transparent for crashpad.
- M infra/config/generated/cr-buildbucket.cfg
- M infra/config/generated/project.cfg
- M infra/config/main.star
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Pastene (Gerrit)
Ben Pastene voted Commit-Queue+2![]( "Open in Gerrit")
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen added 1 comment![]( "Open in Gerrit")
https://ci.chromium.org/p/crashpad/g/main/console looks very red after this change, could it reblated?
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Pastene (Gerrit)
Ben Pastene added 1 comment![]( "Open in Gerrit")
https://ci.chromium.org/p/crashpad/g/main/console looks very red after this change, could it reblated?
Due to a quirk in the timing of how luci config changes propagate, those failed fuchsia builds (eg https://ci.chromium.org/ui/p/crashpad/builders/ci/crashpad_fuchsia_x64_rel/1245/infra) still ran on a bionic machine. So likely unrelated, but I grant you the timing def seems suspicious.
Rather, I think the culprit is the fact that:
- crashpad downloads an unpinned fuchsia sdk: https://chromium.googlesource.com/crashpad/crashpad/+/cd0b7c2cd47b8424ff9f29e1ea8ff97af961fe9e/DEPS#128
- so crashpad builds automatically picked up https://fxrev.dev/1004686 when it landed
- crashpad builds surface warnings as errors (`-Werror`)
Options to fix crasphad fuchsia builds:
- actually resolve the warning ?
- remove `-Werror` ?
- pin fuchsia SDK to something before https://fxrev.dev/1004686 ?
- revert https://fxrev.dev/1004686 ?
mark, david, zijie: thoughts?
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zijie He (Gerrit)
Zijie He added 1 comment![]( "Open in Gerrit")
Ben Pastenehttps://ci.chromium.org/p/crashpad/g/main/console looks very red after this change, could it reblated?
Due to a quirk in the timing of how luci config changes propagate, those failed fuchsia builds (eg https://ci.chromium.org/ui/p/crashpad/builders/ci/crashpad_fuchsia_x64_rel/1245/infra) still ran on a bionic machine. So likely unrelated, but I grant you the timing def seems suspicious.
Rather, I think the culprit is the fact that:
- crashpad downloads an unpinned fuchsia sdk: https://chromium.googlesource.com/crashpad/crashpad/+/cd0b7c2cd47b8424ff9f29e1ea8ff97af961fe9e/DEPS#128
- so crashpad builds automatically picked up https://fxrev.dev/1004686 when it landed
- crashpad builds surface warnings as errors (`-Werror`)
Options to fix crasphad fuchsia builds:
- actually resolve the warning ?
- remove `-Werror` ?
- pin fuchsia SDK to something before https://fxrev.dev/1004686 ?
- revert https://fxrev.dev/1004686 ?
mark, david, zijie: thoughts?
We may want to update the crashpad DEPS to use build/fuchsia/ from chromium and avoid in-house-built build/fuchsia/gen_build_defs.py, it carries the necessary api level definition. But I am not sure if other changes are needed.
This change itself is definitely unrelated to the breakage.
Related details
- Ben Pastene
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zijie He (Gerrit)
Zijie He added 1 comment![]( "Open in Gerrit")
Ben Pastenehttps://ci.chromium.org/p/crashpad/g/main/console looks very red after this change, could it reblated?
Zijie HeDue to a quirk in the timing of how luci config changes propagate, those failed fuchsia builds (eg https://ci.chromium.org/ui/p/crashpad/builders/ci/crashpad_fuchsia_x64_rel/1245/infra) still ran on a bionic machine. So likely unrelated, but I grant you the timing def seems suspicious.
Rather, I think the culprit is the fact that:
- crashpad downloads an unpinned fuchsia sdk: https://chromium.googlesource.com/crashpad/crashpad/+/cd0b7c2cd47b8424ff9f29e1ea8ff97af961fe9e/DEPS#128
- so crashpad builds automatically picked up https://fxrev.dev/1004686 when it landed
- crashpad builds surface warnings as errors (`-Werror`)
Options to fix crasphad fuchsia builds:
- actually resolve the warning ?
- remove `-Werror` ?
- pin fuchsia SDK to something before https://fxrev.dev/1004686 ?
- revert https://fxrev.dev/1004686 ?
mark, david, zijie: thoughts?
We may want to update the crashpad DEPS to use build/fuchsia/ from chromium and avoid in-house-built build/fuchsia/gen_build_defs.py, it carries the necessary api level definition. But I am not sure if other changes are needed.
This change itself is definitely unrelated to the breakage.
I can take a look this afternoon.
Related details
- Ben Pastene
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zijie He (Gerrit)
Zijie He added 1 comment![]( "Open in Gerrit")
Ben Pastenehttps://ci.chromium.org/p/crashpad/g/main/console looks very red after this change, could it reblated?
Zijie HeDue to a quirk in the timing of how luci config changes propagate, those failed fuchsia builds (eg https://ci.chromium.org/ui/p/crashpad/builders/ci/crashpad_fuchsia_x64_rel/1245/infra) still ran on a bionic machine. So likely unrelated, but I grant you the timing def seems suspicious.
Rather, I think the culprit is the fact that:
- crashpad downloads an unpinned fuchsia sdk: https://chromium.googlesource.com/crashpad/crashpad/+/cd0b7c2cd47b8424ff9f29e1ea8ff97af961fe9e/DEPS#128
- so crashpad builds automatically picked up https://fxrev.dev/1004686 when it landed
- crashpad builds surface warnings as errors (`-Werror`)
Options to fix crasphad fuchsia builds:
- actually resolve the warning ?
- remove `-Werror` ?
- pin fuchsia SDK to something before https://fxrev.dev/1004686 ?
- revert https://fxrev.dev/1004686 ?
mark, david, zijie: thoughts?
Zijie HeWe may want to update the crashpad DEPS to use build/fuchsia/ from chromium and avoid in-house-built build/fuchsia/gen_build_defs.py, it carries the necessary api level definition. But I am not sure if other changes are needed.
This change itself is definitely unrelated to the breakage.
I can take a look this afternoon.
Done
Related details
- Ben Pastene
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |