iOS: Explicitly ignore return value of vector::at() [crashpad/crashpad : main]

9 views
Skip to first unread message

Mark Mentovai (Gerrit)

unread,
Aug 1, 2025, 11:48:47 AMAug 1
to Nico Weber, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Nico Weber

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b9d304f693958236f839814ec427d8171c13578
Gerrit-Change-Number: 6812474
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Aug 2025 15:48:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Aug 1, 2025, 11:50:27 AMAug 1
to Nico Weber, Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org

Nico Weber voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b9d304f693958236f839814ec427d8171c13578
Gerrit-Change-Number: 6812474
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Aug 2025 15:50:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Aug 1, 2025, 11:50:38 AMAug 1
to Nico Weber, Mark Mentovai, Justin Cohen, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
iOS: Explicitly ignore return value of vector::at()

This upstreams https://chromium-review.googlesource.com/c/chromium/src/+/6803484

No behavior change.
Bug: none
Change-Id: I5b9d304f693958236f839814ec427d8171c13578
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Nico Weber <tha...@chromium.org>
Change size: XS
Delta: 2 files changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b9d304f693958236f839814ec427d8171c13578
Gerrit-Change-Number: 6812474
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Justin Cohen <justi...@chromium.org>
open
diffy
satisfied_requirement

Justin Cohen (Gerrit)

unread,
Aug 1, 2025, 11:52:05 AMAug 1
to Crashpad LUCI CQ, Nico Weber, Mark Mentovai, crashp...@chromium.org

Justin Cohen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I5b9d304f693958236f839814ec427d8171c13578
Gerrit-Change-Number: 6812474
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Fri, 01 Aug 2025 15:52:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages