Roll xnu to 12377.1.9 (from macOS 26.0) [crashpad/crashpad : main]

6 views
Skip to first unread message

Justin Cohen (Gerrit)

unread,
Nov 25, 2025, 3:48:04 PMNov 25
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Justin Cohen added 2 comments

File third_party/xnu/README.crashpad
Line 4, Patchset 5:Version: 12377.1.9 (from macOS 26.0.0)
Mark Mentovai . resolved

Just 26.0 here too.

Justin Cohen

Done

File third_party/xnu/osfmk/mach/std_types.defs
Line 65, Patchset 5:import <Availability.h>;
Mark Mentovai . unresolved

Wonder if this needs special handling. How does this transform the output?

Justin Cohen

gen/third_party/crashpad/crashpad/util/mach/exc.h
and
gen/third_party/crashpad/crashpad/util/mach/excServer.h

Both contain:
#include <Availability.h>

I wonder if the Crashpad trybots need a clobber to test this?

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
Gerrit-Change-Number: 7205002
Gerrit-PatchSet: 7
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 20:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Nov 25, 2025, 3:58:11 PMNov 25
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Justin Cohen added 1 comment

File third_party/xnu/osfmk/mach/std_types.defs
Line 65, Patchset 5:import <Availability.h>;
Mark Mentovai . unresolved

Wonder if this needs special handling. How does this transform the output?

Justin Cohen

gen/third_party/crashpad/crashpad/util/mach/exc.h
and
gen/third_party/crashpad/crashpad/util/mach/excServer.h

Both contain:
#include <Availability.h>

I wonder if the Crashpad trybots need a clobber to test this?

Justin Cohen

Only mac/ios will use this, right? Any reason it would cause a problem?

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
Gerrit-Change-Number: 7205002
Gerrit-PatchSet: 7
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 20:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
Comment-In-Reply-To: Justin Cohen <justi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Nov 25, 2025, 4:20:44 PMNov 25
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Mark Mentovai voted and added 1 comment

Votes added by Mark Mentovai

Code-Review+1

1 comment

File third_party/xnu/osfmk/mach/std_types.defs
Line 65, Patchset 5:import <Availability.h>;
Mark Mentovai . resolved

Wonder if this needs special handling. How does this transform the output?

Justin Cohen

gen/third_party/crashpad/crashpad/util/mach/exc.h
and
gen/third_party/crashpad/crashpad/util/mach/excServer.h

Both contain:
#include <Availability.h>

I wonder if the Crashpad trybots need a clobber to test this?

Justin Cohen

Only mac/ios will use this, right? Any reason it would cause a problem?

Mark Mentovai

Only mac/ios will use this, right?

Right.

Any reason it would cause a problem?

Nope.

That header’s not used by this file (or what it generates) as far as I can tell, but Apple’s got some very uniquely weird ideas about the header, so I guess it’s not so surprising to see it here.

I wonder if the Crashpad trybots need a clobber to test this?

Don’t think so—touching these files should be enough to get everything downstream of them to rebuild.

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
Gerrit-Change-Number: 7205002
Gerrit-PatchSet: 7
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 21:20:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Nov 25, 2025, 4:46:06 PMNov 25
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Justin Cohen voted and added 1 comment

Votes added by Justin Cohen

Commit-Queue+2

1 comment

Commit Message
Line 7, Patchset 5:Roll xnu to 12377.1.9 (from macOS 26.0.0)
Mark Mentovai . resolved

Just 26.0.

Justin Cohen

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
    Gerrit-Change-Number: 7205002
    Gerrit-PatchSet: 7
    Gerrit-Owner: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Tue, 25 Nov 2025 21:46:03 +0000
    satisfied_requirement
    open
    diffy

    Crashpad LUCI CQ (Gerrit)

    unread,
    Nov 25, 2025, 5:11:29 PMNov 25
    to Justin Cohen, Mark Mentovai, crashp...@chromium.org

    Crashpad LUCI CQ submitted the change

    Change information

    Commit message:
    Roll xnu to 12377.1.9 (from macOS 26.0)
    Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
    Commit-Queue: Justin Cohen <justi...@chromium.org>
    Reviewed-by: Mark Mentovai <ma...@chromium.org>
    Files:
    • M third_party/xnu/EXTERNAL_HEADERS/mach-o/loader.h
    • M third_party/xnu/README.crashpad
    • M third_party/xnu/osfmk/mach/exc.defs
    • M third_party/xnu/osfmk/mach/mach_exc.defs
    • M third_party/xnu/osfmk/mach/mach_types.defs
    • M third_party/xnu/osfmk/mach/machine/machine_types.defs
    • M third_party/xnu/osfmk/mach/std_types.defs
    Change size: L
    Delta: 7 files changed, 277 insertions(+), 92 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mark Mentovai
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
    Gerrit-Change-Number: 7205002
    Gerrit-PatchSet: 8
    Gerrit-Owner: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages