ios_system_data_collector: Do not monitor orientation changes on tvOS [crashpad/crashpad : main]

3 views
Skip to first unread message

Raphael Kubo da Costa (Gerrit)

unread,
Apr 1, 2025, 2:19:15 PM4/1/25
to Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Gerrit-Change-Number: 6420428
Gerrit-PatchSet: 1
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-CC: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Tue, 01 Apr 2025 18:19:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Apr 4, 2025, 1:17:02 PM4/4/25
to Raphael Kubo da Costa, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Raphael Kubo da Costa

Justin Cohen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Raphael Kubo da Costa
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Gerrit-Change-Number: 6420428
Gerrit-PatchSet: 2
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-CC: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-Attention: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Fri, 04 Apr 2025 17:16:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Raphael Kubo da Costa (Gerrit)

unread,
May 14, 2025, 6:09:09 PM5/14/25
to Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org

Raphael Kubo da Costa voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Gerrit-Change-Number: 6420428
Gerrit-PatchSet: 4
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-CC: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-Comment-Date: Wed, 14 May 2025 22:09:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 14, 2025, 6:09:16 PM5/14/25
to Raphael Kubo da Costa, Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
ios_system_data_collector: Do not monitor orientation changes on tvOS

The `[UIDevice orientation]` property does not exist on tvOS, so make
sure this API is only used on iPhones. In the tvOS case, the orientation
will always be 0.
Bug: 405140658
Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Commit-Queue: Raphael Kubo da Costa <ku...@igalia.com>
Reviewed-by: Justin Cohen <justi...@chromium.org>
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Justin Cohen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Gerrit-Change-Number: 6420428
Gerrit-PatchSet: 5
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages