ios_system_data_collector: Do not monitor orientation changes on tvOS [crashpad/crashpad : main]
3 views
Skip to first unread message
Raphael Kubo da Costa (Gerrit)
Apr 1, 2025, 2:19:15 PM4/1/25
to Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Apr 4, 2025, 1:17:02 PM4/4/25
to Raphael Kubo da Costa, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Raphael Kubo da Costa
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Raphael Kubo da Costa
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
May 14, 2025, 6:09:09 PM5/14/25
to Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, Crashpad LUCI CQ, crashp...@chromium.org
Raphael Kubo da Costa voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 14, 2025, 6:09:16 PM5/14/25
to Raphael Kubo da Costa, Justin Cohen, Abhijeet Kandalkar, Miguel Casas-Sanchez, Gyuyoung Kim, Julie Jeongeun Kim, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
ios_system_data_collector: Do not monitor orientation changes on tvOS
The `[UIDevice orientation]` property does not exist on tvOS, so make
sure this API is only used on iPhones. In the tvOS case, the orientation
will always be 0.
Bug: 405140658
Change-Id: I0859add14aa6e16fa9b575709e0ba2ced626cdd3
Commit-Queue: Raphael Kubo da Costa <ku...@igalia.com>
Reviewed-by: Justin Cohen <justi...@chromium.org>
Files:
- M util/ios/ios_system_data_collector.mm
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages