Increase delay in crashpad_util_test ServiceManagement.SubmitRemoveJob [crashpad/crashpad : main]

2 views
Skip to first unread message

Mark Mentovai (Gerrit)

unread,
Jul 28, 2025, 5:17:16 PMJul 28
to Joshua Peraza, Jesse McKenna, crashp...@chromium.org
Attention needed from Joshua Peraza

Mark Mentovai voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joshua Peraza
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I697ef96e0b382ccea24d7983fcc53a1c21858f80
Gerrit-Change-Number: 6794724
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Jesse McKenna <jessem...@google.com>
Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
Gerrit-Comment-Date: Mon, 28 Jul 2025 21:17:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joshua Peraza (Gerrit)

unread,
Jul 28, 2025, 5:18:33 PMJul 28
to Mark Mentovai, Crashpad LUCI CQ, Jesse McKenna, crashp...@chromium.org
Attention needed from Mark Mentovai

Joshua Peraza voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I697ef96e0b382ccea24d7983fcc53a1c21858f80
Gerrit-Change-Number: 6794724
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Jesse McKenna <jessem...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 28 Jul 2025 21:18:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jul 28, 2025, 6:52:23 PMJul 28
to Joshua Peraza, Crashpad LUCI CQ, Jesse McKenna, crashp...@chromium.org

Mark Mentovai voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I697ef96e0b382ccea24d7983fcc53a1c21858f80
Gerrit-Change-Number: 6794724
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Jesse McKenna <jessem...@google.com>
Gerrit-Comment-Date: Mon, 28 Jul 2025 22:52:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Jul 28, 2025, 6:52:32 PMJul 28
to Mark Mentovai, Joshua Peraza, Jesse McKenna, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Increase delay in crashpad_util_test ServiceManagement.SubmitRemoveJob

Running macOS 15.5 24F74 on a MacBookPro18,2, this test was flaky with
an inner sleep of 1ms, but passes reliably at 10ms.
Change-Id: I697ef96e0b382ccea24d7983fcc53a1c21858f80
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joshua Peraza
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I697ef96e0b382ccea24d7983fcc53a1c21858f80
Gerrit-Change-Number: 6794724
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Jesse McKenna <jessem...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages