Busybody: Format GN files [crashpad/crashpad : main]

5 views
Skip to first unread message

Kalvin Lee (Gerrit)

unread,
Jun 1, 2026, 6:04:01 AM (5 days ago) Jun 1
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai

Kalvin Lee added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved

Drop inactive / OOO reviewers -> roll d3 on Gerrit-suggested reviewers -> 3 -> Mark to review, please.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I20834b0dd3e1f08a0058f7ee68b993b1f16e26ab
Gerrit-Change-Number: 7885561
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 10:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jun 1, 2026, 8:53:44 AM (5 days ago) Jun 1
to Kalvin Lee, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Kalvin Lee

Mark Mentovai voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kalvin Lee
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I20834b0dd3e1f08a0058f7ee68b993b1f16e26ab
Gerrit-Change-Number: 7885561
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Kalvin Lee <kd...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 12:53:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 1, 2026, 8:54:00 AM (5 days ago) Jun 1
to Kalvin Lee, Mark Mentovai, crashp...@chromium.org

crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Busybody: Format GN files

This CL introduces no behavioral change. It was generated by issuing

```
git ls-files -- '*.gni' '*.gn' \
  | xargs gn format
```

just to prevent unlucky folks from having to deal with a presubmit
error about formatting, forcing them to introduce an unrelated diff to
their CL.
Bug: 515185457
Change-Id: I20834b0dd3e1f08a0058f7ee68b993b1f16e26ab
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Files:
  • M third_party/zlib/BUILD.gn
Change size: XS
Delta: 1 file changed, 1 insertion(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I20834b0dd3e1f08a0058f7ee68b993b1f16e26ab
Gerrit-Change-Number: 7885561
Gerrit-PatchSet: 2
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages