Update base/BUILD.gn with new headers [chromium/mini_chromium : main]

4 views
Skip to first unread message

danakj (Gerrit)

unread,
May 21, 2024, 2:55:19 PMMay 21
to Ben Hamilton, Mark Mentovai, crashp...@chromium.org
Attention needed from Ben Hamilton

danakj voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ben Hamilton
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I67d92f368064271546e5cd84408cf8d970471b14
Gerrit-Change-Number: 5554482
Gerrit-PatchSet: 3
Gerrit-Owner: Ben Hamilton <benha...@google.com>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Ben Hamilton <benha...@google.com>
Gerrit-Comment-Date: Tue, 21 May 2024 18:55:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

danakj (Gerrit)

unread,
May 21, 2024, 2:55:25 PMMay 21
to Ben Hamilton, Mark Mentovai, crashp...@chromium.org

danakj submitted the change

Change information

Commit message:
Update base/BUILD.gn with new headers

https://crrev.com/c/5414953 forgot to add the new headers to
base/BUILD.gn.

This adds the new files.
Bug: chromium: 40284755
Change-Id: I67d92f368064271546e5cd84408cf8d970471b14
Reviewed-by: danakj <dan...@chromium.org>
Files:
  • M base/BUILD.gn
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by danakj
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I67d92f368064271546e5cd84408cf8d970471b14
Gerrit-Change-Number: 5554482
Gerrit-PatchSet: 4
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages