pull latest fuchsia toolchain [crashpad/crashpad : main]
0 views
Skip to first unread message
Mark Mentovai (Gerrit)
May 10, 2024, 12:58:41 PMMay 10
to Arthur Wang, Crashpad LUCI CQ, Thomas Gales, crashp...@chromium.org
Attention needed from Arthur Wang and Thomas Gales
Mark Mentovai added 2 comments![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2 (Latest):
pull latest fuchsia toolchainMark Mentovai . unresolved
The commit message should use proper capitalization: start with a capital letter, capitalize proper names like Fuchsia.
Line 9, Patchset 2 (Latest):
Bug: crashpad:326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694Mark Mentovai . unresolved
These bugs don’t have anything to do with this. Remove this line.
Related details
Attention is currently required from:
- Arthur Wang
- Thomas Gales
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Gales (Gerrit)
May 10, 2024, 1:00:19 PMMay 10
to Arthur Wang, Crashpad LUCI CQ, Mark Mentovai, crashp...@chromium.org
Attention needed from Arthur Wang
Thomas Gales added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Gales . resolved
Seems I don't have permission to vote, but LGTM with Mark's comments addressed
Related details
Attention is currently required from:
- Arthur Wang
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages