run_tests.py: Add support for tvOS [crashpad/crashpad : main]
2 views
Skip to first unread message
Raphael Kubo da Costa (Gerrit)
Apr 1, 2025, 11:09:16 AM4/1/25
to Justin Cohen, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Apr 1, 2025, 1:16:14 PM4/1/25
to Raphael Kubo da Costa, Joshua Peraza, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Raphael Kubo da Costa
Justin Cohen added 3 comments![]( "Open in Gerrit")
File build/run_tests.py
Line 74, Patchset 2 (Parent):
'--list=target_os', '--short'Justin Cohen . unresolved
Why move from --short to --json, and instead just --list argument_name and match argument_name?
Line 87, Patchset 2 (Parent):
# to ar. This path is configured by gyp_crashpad_android.py.Justin Cohen . unresolved
I think this should have gone away in 2021 with this change: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3034984
Line 447, Patchset 2 (Latest):
if target_os is None:
# For GYP with Ninja, look for the appearance of “linux-android” in the
# path to ar. This path is configured by gyp_crashpad_android.py.
build_ninja_path = os.path.join(args.binary_dir, 'build.ninja')
if os.path.exists(build_ninja_path):
with open(build_ninja_path) as build_ninja_file:
build_ninja_content = build_ninja_file.read()
match = re.search(r'-linux-android(eabi)?-ar$',
build_ninja_content,
flags=re.MULTILINE)
if match:
target_os = 'android'Justin Cohen . unresolved
jperaza@ do we still need this?
Related details
Attention is currently required from:
- Raphael Kubo da Costa
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Apr 1, 2025, 1:55:51 PM4/1/25
to Raphael Kubo da Costa, Justin Cohen, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen and Raphael Kubo da Costa
Joshua Peraza added 1 comment![]( "Open in Gerrit")
File build/run_tests.py
Line 447, Patchset 2 (Latest):
if target_os is None:
# For GYP with Ninja, look for the appearance of “linux-android” in the
# path to ar. This path is configured by gyp_crashpad_android.py.
build_ninja_path = os.path.join(args.binary_dir, 'build.ninja')
if os.path.exists(build_ninja_path):
with open(build_ninja_path) as build_ninja_file:
build_ninja_content = build_ninja_file.read()
match = re.search(r'-linux-android(eabi)?-ar$',
build_ninja_content,
flags=re.MULTILINE)
if match:
target_os = 'android'Justin Cohen . resolved
jperaza@ do we still need this?
Joshua Peraza
I think no. Prior to this change the comment was outdated, but the code still good. GN generated build.ninja instead of gyp_crashpad_android.py. This change to look at GN args instead of build.ninja also seems fine.
Related details
Attention is currently required from:
- Justin Cohen
- Raphael Kubo da Costa
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
Apr 1, 2025, 2:27:06 PM4/1/25
to Joshua Peraza, Justin Cohen, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
Raphael Kubo da Costa added 2 comments![]( "Open in Gerrit")
File build/run_tests.py
Line 74, Patchset 2 (Parent):
'--list=target_os', '--short'Justin Cohen . resolved
Why move from --short to --json, and instead just --list argument_name and match argument_name?
Raphael Kubo da Costa
I thought it would look cleaner, but in retrospect the previous approach is much more concise. I've reverted back to parsing `--short`'s output.
Line 87, Patchset 2 (Parent):
# to ar. This path is configured by gyp_crashpad_android.py.Justin Cohen . resolved
I think this should have gone away in 2021 with this change: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3034984
Raphael Kubo da Costa
Oh cool, done. I've also mentioned this in the CL description.
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Apr 1, 2025, 6:46:55 PM4/1/25
to Raphael Kubo da Costa, Joshua Peraza, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Raphael Kubo da Costa
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Raphael Kubo da Costa
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
May 14, 2025, 6:08:45 PM5/14/25
to Justin Cohen, Joshua Peraza, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, Crashpad LUCI CQ, crashp...@chromium.org
Raphael Kubo da Costa voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 14, 2025, 6:08:51 PM5/14/25
to Raphael Kubo da Costa, Justin Cohen, Joshua Peraza, Julie Jeongeun Kim, Gyuyoung Kim, Abhijeet Kandalkar, Miguel Casas-Sanchez, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
run_tests.py: Add support for tvOS
We need to differentiate between iOS and tvOS builds in order to pass
the right environment variables to xcodebuild.
We do this by generalizing _BinaryDirTargetOS() for any variable in
args.gn and reading `target_platform`'s value to determine the kind of
build we have.
While here, remove the linux-android-specific target_os detection
workaround, which has not been necessary since
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3034984
Bug: 405140658
Change-Id: I7cc5ad2a60ce077d38a0f4d60c68b45e21f47e0c
Reviewed-by: Justin Cohen <justi...@chromium.org>
Commit-Queue: Raphael Kubo da Costa <ku...@igalia.com>
Files:
- M build/run_tests.py
Change size: M
Delta: 1 file changed, 36 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages