Use NOTREACHED_IN_MIGRATION() [crashpad/crashpad : main]
4 views
Skip to first unread message
Peter Boström (Gerrit)
May 17, 2024, 9:53:33 AMMay 17
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Peter Boström voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter Boström
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 17, 2024, 10:09:21 AMMay 17
to Peter Boström, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Peter Boström
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Peter Boström
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Boström (Gerrit)
May 17, 2024, 12:30:48 PMMay 17
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Peter Boström voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 17, 2024, 12:30:56 PMMay 17
to Peter Boström, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use NOTREACHED_IN_MIGRATION()
This was generated by replacing " NOTREACHED()" with
" NOTREACHED_IN_MIGRATION()" and running git cl format.
This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.
Bug: chromium:40580068
Change-Id: Idb68e2fc8adba180350b0595fd494cf0f206bded
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Peter Boström <pb...@chromium.org>
Files:
- M client/crashpad_client_linux_test.cc
- M client/prune_crash_reports.cc
- M client/settings.cc
- M handler/crash_report_upload_thread.cc
- M handler/win/hanging_program.cc
- M minidump/minidump_context_writer_test.cc
- M minidump/minidump_string_writer_test.cc
- M minidump/minidump_system_info_writer.cc
- M snapshot/cpu_context.cc
- M snapshot/fuchsia/process_snapshot_fuchsia.cc
- M snapshot/fuchsia/system_snapshot_fuchsia.cc
- M snapshot/linux/system_snapshot_linux.cc
- M snapshot/mac/cpu_context_mac.cc
- M snapshot/mac/system_snapshot_mac.cc
- M snapshot/minidump/module_snapshot_minidump.cc
- M snapshot/minidump/process_snapshot_minidump.cc
- M snapshot/minidump/system_snapshot_minidump.cc
- M snapshot/sanitized/process_snapshot_sanitized_test.cc
- M snapshot/win/system_snapshot_win.cc
- M test/linux/fake_ptrace_connection.cc
- M util/file/file_io_posix.cc
- M util/file/file_io_win.cc
- M util/file/output_stream_file_writer.cc
- M util/mac/mac_util.cc
- M util/mach/child_port_handshake.cc
- M util/mach/exc_client_variants.cc
- M util/mach/exception_ports.cc
- M util/mach/exception_ports_test.cc
- M util/synchronization/scoped_spin_guard.h
- M util/win/registration_protocol_win_test.cc
Change size: M
Delta: 30 files changed, 74 insertions(+), 73 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages