Mark, can you PTAL or add an appropriate reviewer?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua, what do you think about the test failures?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua, what do you think about the test failures?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua PerazaJoshua, what do you think about the test failures?
I think the test stacks need guard pages.
Or don't test user-allocated stacks.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua PerazaJoshua, what do you think about the test failures?
Joshua PerazaI think the test stacks need guard pages.
Or don't test user-allocated stacks.
I think the test stacks need guard pages.
That sounds plausible, based on how this is failing:
```
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:317: Failure
Expected: (thread.stack_region_size) < (iterator->second.max_stack_size), actual: 34120 vs 16384
Google Test trace:
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:293: Thread id 7088, name ThreadPool-0, tls 0x7d87158aa000, stack addr 0x740003efab8, stack size 0x8548
```
```
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:317: Failure
Expected: (thread.stack_region_size) < (iterator->second.max_stack_size), actual: 17736 vs 16384
Google Test trace:
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:293: Thread id 7089, name ThreadPool-1, tls 0x7d8715773000, stack addr 0x740003f3ab8, stack size 0x4548
```
If the mapping containing the stack is hosting more than just the stack, we could fail to detect the bounds of the stack properly. Guard pages would help.
I’m reluctant to just give up on this test altogether, because we do want some assurance that we’re doing a reasonable job of detecting stack sizes.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |