[Gardener] Disabling Failing ProcessReaderLinux.ChildThreadsWithSmallUserStacks [crashpad/crashpad : main]

5 views
Skip to first unread message

Adam Walls (Gerrit)

unread,
May 14, 2024, 6:57:48 PMMay 14
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Adam Walls added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Adam Walls . resolved

Mark, can you PTAL or add an appropriate reviewer?

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 14 May 2024 22:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 14, 2024, 6:59:28 PMMay 14
to Adam Walls, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Adam Walls and Joshua Peraza

Mark Mentovai added 1 comment

Patchset-level comments
Mark Mentovai . unresolved

Joshua, what do you think about the test failures?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Walls
  • Joshua Peraza
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
Gerrit-Attention: Adam Walls <avv...@chromium.org>
Gerrit-Comment-Date: Tue, 14 May 2024 22:59:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Joshua Peraza (Gerrit)

unread,
May 14, 2024, 7:53:37 PMMay 14
to Adam Walls, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Adam Walls and Mark Mentovai

Joshua Peraza added 1 comment

Patchset-level comments
Mark Mentovai . unresolved

Joshua, what do you think about the test failures?

Joshua Peraza

I think the test stacks need guard pages.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Walls
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Adam Walls <avv...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 14 May 2024 23:53:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Joshua Peraza (Gerrit)

unread,
May 14, 2024, 8:36:18 PMMay 14
to Adam Walls, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Adam Walls and Mark Mentovai

Joshua Peraza added 1 comment

Patchset-level comments
Mark Mentovai . unresolved

Joshua, what do you think about the test failures?

Joshua Peraza

I think the test stacks need guard pages.

Joshua Peraza

Or don't test user-allocated stacks.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Walls
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Adam Walls <avv...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 15 May 2024 00:36:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Peraza <jpe...@chromium.org>
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 15, 2024, 10:03:26 AMMay 15
to Adam Walls, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Adam Walls and Joshua Peraza

Mark Mentovai added 1 comment

Patchset-level comments
Mark Mentovai . unresolved

Joshua, what do you think about the test failures?

Joshua Peraza

I think the test stacks need guard pages.

Joshua Peraza

Or don't test user-allocated stacks.

Mark Mentovai

I think the test stacks need guard pages.

That sounds plausible, based on how this is failing:

https://ci.chromium.org/ui/p/chromium/builders/ci/android-14-x64-rel/1416/test-results?q=ID%3Aninja%3A%2F%2Fthird_party%2Fcrashpad%2Fcrashpad%3Acrashpad_tests%2FProcessReaderLinux.ChildThreadsWithSmallUserStacks+V%3Abuilder%3Dandroid-14-x64-rel+V%3Aos%3DUbuntu-22.04+V%3Atest_suite%3Dcrashpad_tests&sortby=&groupby=

```
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:317: Failure
Expected: (thread.stack_region_size) < (iterator->second.max_stack_size), actual: 34120 vs 16384
Google Test trace:
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:293: Thread id 7088, name ThreadPool-0, tls 0x7d87158aa000, stack addr 0x740003efab8, stack size 0x8548
```
```
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:317: Failure
Expected: (thread.stack_region_size) < (iterator->second.max_stack_size), actual: 17736 vs 16384
Google Test trace:
../../third_party/crashpad/crashpad/snapshot/linux/process_reader_linux_test.cc:293: Thread id 7089, name ThreadPool-1, tls 0x7d8715773000, stack addr 0x740003f3ab8, stack size 0x4548
```

If the mapping containing the stack is hosting more than just the stack, we could fail to detect the bounds of the stack properly. Guard pages would help.

I’m reluctant to just give up on this test altogether, because we do want some assurance that we’re doing a reasonable job of detecting stack sizes.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Walls
  • Joshua Peraza
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
Gerrit-Attention: Adam Walls <avv...@chromium.org>
Gerrit-Comment-Date: Wed, 15 May 2024 14:03:21 +0000
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 16, 2024, 12:36:07 PMMay 16
to Adam Walls, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Adam Walls and Joshua Peraza

Mark Mentovai added 1 comment

Patchset-level comments
Mark Mentovai . resolved
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Walls
  • Joshua Peraza
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4579802826ac1b765a01045f1c8b53beed516b7b
Gerrit-Change-Number: 5537877
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Adam Walls <avv...@chromium.org>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
Gerrit-Attention: Adam Walls <avv...@chromium.org>
Gerrit-Comment-Date: Thu, 16 May 2024 16:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages