Update googletest to fix fuchsia [crashpad/crashpad : main]

6 views
Skip to first unread message

Zijie He (Gerrit)

unread,
Jul 11, 2025, 3:39:40 PMJul 11
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Zijie He voted and added 1 comment

Votes added by Zijie He

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Zijie He . resolved

Please take a look, thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Gerrit-Change-Number: 6729599
Gerrit-PatchSet: 1
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 11 Jul 2025 19:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Jul 11, 2025, 3:40:51 PMJul 11
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Zijie He voted

Code-Review+0
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Gerrit-Change-Number: 6729599
Gerrit-PatchSet: 1
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 11 Jul 2025 19:40:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jul 11, 2025, 4:28:15 PMJul 11
to Zijie He, Brian Bosak, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Zijie He

Mark Mentovai voted and added 1 comment

Votes added by Mark Mentovai

Code-Review+1

1 comment

Patchset-level comments
Mark Mentovai . resolved

Thanks, Zijie!

Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Gerrit-Change-Number: 6729599
Gerrit-PatchSet: 1
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Brian Bosak <bbo...@google.com>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 20:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Jul 11, 2025, 4:28:58 PMJul 11
to Mark Mentovai, Brian Bosak, Crashpad LUCI CQ, crashp...@chromium.org

Zijie He voted and added 1 comment

Votes added by Zijie He

Commit-Queue+2

1 comment

Patchset-level comments
Zijie He . resolved

My pleasure :)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Gerrit-Change-Number: 6729599
Gerrit-PatchSet: 1
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Brian Bosak <bbo...@google.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 20:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Jul 11, 2025, 4:29:20 PMJul 11
to Zijie He, Mark Mentovai, Brian Bosak, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Update googletest to fix fuchsia

The out-dated googletest is triggering a compiler warning from a newer
compiler, and simply updating it would fix the issue.
Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Zijie He <zij...@google.com>
Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +0 by Zijie He, +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I4f1eabfd881c0ac2b653838a7fb71ebdebb52a7e
Gerrit-Change-Number: 6729599
Gerrit-PatchSet: 2
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages