return a bool from LogOutputStream::Delegate::Log [crashpad/crashpad : main]
4 views
Skip to first unread message
Joshua Peraza (Gerrit)
Jul 24, 2025, 8:55:09 PMJul 24
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai
Joshua Peraza voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2025, 10:10:13 PMJul 24
to Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Jul 24, 2025, 10:12:51 PMJul 24
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Joshua Peraza voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Jul 24, 2025, 10:13:00 PMJul 24
to Joshua Peraza, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
return a bool from LogOutputStream::Delegate::Log
__android_log_buf_write() has been updated to no longer return
-EAGAIN. It now returns 1 on success, otherwise -EPERM.
Change-Id: I3f78d25ca773bb3d580612454dded002084095db
Commit-Queue: Joshua Peraza <jpe...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M handler/linux/crash_report_exception_handler.cc
- M util/stream/log_output_stream.cc
- M util/stream/log_output_stream.h
- M util/stream/log_output_stream_test.cc
Change size: S
Delta: 4 files changed, 10 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages