Allow preserving file descriptors in StartHandlerWithLinker variants [crashpad/crashpad : main]

9 views
Skip to first unread message

Jesse McKenna (Gerrit)

unread,
Sep 4, 2026, 6:53:21 PMSep 4
to Oskar Świerczek, Code Review Nudger, Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai and Oskar Świerczek

Jesse McKenna voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
  • Oskar Świerczek
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ifae240d1065ded9fbe7e99af14a4ed6f7df89463
Gerrit-Change-Number: 8314688
Gerrit-PatchSet: 2
Gerrit-Owner: Oskar Świerczek <oswie...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Oskar Świerczek <oswie...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Oskar Świerczek <oswie...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 04 Sep 2026 22:53:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Sep 4, 2026, 7:14:30 PMSep 4
to Oskar Świerczek, Code Review Nudger, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Oskar Świerczek

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Oskar Świerczek
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ifae240d1065ded9fbe7e99af14a4ed6f7df89463
Gerrit-Change-Number: 8314688
Gerrit-PatchSet: 2
Gerrit-Owner: Oskar Świerczek <oswie...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Oskar Świerczek <oswie...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Oskar Świerczek <oswie...@google.com>
Gerrit-Comment-Date: Fri, 04 Sep 2026 23:14:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Oskar Świerczek (Gerrit)

unread,
Sep 7, 2026, 4:08:16 AMSep 7
to Mark Mentovai, Code Review Nudger, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Oskar Świerczek voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ifae240d1065ded9fbe7e99af14a4ed6f7df89463
Gerrit-Change-Number: 8314688
Gerrit-PatchSet: 2
Gerrit-Owner: Oskar Świerczek <oswie...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Oskar Świerczek <oswie...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Comment-Date: Mon, 07 Sep 2026 08:08:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Sep 7, 2026, 4:22:21 AMSep 7
to Oskar Świerczek, Mark Mentovai, Jesse McKenna, Code Review Nudger, crashp...@chromium.org

crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Allow preserving file descriptors in StartHandlerWithLinker variants

Support preserve_fds in StartHandlerWithLinkerAtCrash and
StartHandlerWithLinkerForClient on Android, and clear FD_CLOEXEC
at crash time so the handler inherits the required descriptors.
Bug: 514425492
Change-Id: Ifae240d1065ded9fbe7e99af14a4ed6f7df89463
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Oskar Świerczek <oswie...@google.com>
Reviewed-by: Jesse McKenna <jessem...@google.com>
Files:
  • M client/crashpad_client.h
  • M client/crashpad_client_linux.cc
  • M util/posix/close_multiple.cc
  • M util/posix/close_multiple.h
  • M util/posix/spawn_subprocess.cc
Change size: M
Delta: 5 files changed, 58 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jesse McKenna, +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ifae240d1065ded9fbe7e99af14a4ed6f7df89463
Gerrit-Change-Number: 8314688
Gerrit-PatchSet: 3
Gerrit-Owner: Oskar Świerczek <oswie...@google.com>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Oskar Świerczek <oswie...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages