Add checked_iterators.h and its deps [chromium/mini_chromium : main]
danakj (Gerrit)
danakj added 1 comment![]( "Open in Gerrit")
Related details
- Mark Mentovai
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
- danakj
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai submitted the change![]( "Open in Gerrit")
Change information
Add checked_iterators.h and its deps
This header is needed for span.h.
The RAW_PTR_EXCLUSION define comes from PartitionAlloc which is not
present in mini_chromium, so it's just defined to a no-op.
- A base/containers/checked_iterators.h
- A base/containers/util.h
- A base/memory/raw_ptr_exclusion.h
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Hamilton (Gerrit)
Ben Hamilton added 1 comment![]( "Open in Gerrit")
It seems like nothing added this to `BUILD.gn`. Was that intentional?
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
danakj (Gerrit)
danakj added 1 comment![]( "Open in Gerrit")
It seems like nothing added this to `BUILD.gn`. Was that intentional?
Nope..oops. Would you like to?
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Hamilton (Gerrit)
Ben Hamilton added 1 comment![]( "Open in Gerrit")
It seems like nothing added this to `BUILD.gn`. Was that intentional?
(where "this" is `base/containers/util.h` and `base/containers/checked_iterators.h`).
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Hamilton (Gerrit)
Ben Hamilton added 1 comment![]( "Open in Gerrit")
Ben HamiltonIt seems like nothing added this to `BUILD.gn`. Was that intentional?
(where "this" is `base/containers/util.h` and `base/containers/checked_iterators.h`).
Sure, I can send a CL. I'm surprised it builds without that, but I'm not a `gn` expert.
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
danakj (Gerrit)
danakj added 1 comment![]( "Open in Gerrit")
Ben HamiltonIt seems like nothing added this to `BUILD.gn`. Was that intentional?
Ben Hamilton(where "this" is `base/containers/util.h` and `base/containers/checked_iterators.h`).
Sure, I can send a CL. I'm surprised it builds without that, but I'm not a `gn` expert.
it would i think only have an issue with remote compilation if it depends on the GN to upload files, which i guess crashpad does not or something. thanks :)
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Hamilton (Gerrit)
Ben Hamilton added 1 comment![]( "Open in Gerrit")
Ben HamiltonIt seems like nothing added this to `BUILD.gn`. Was that intentional?
Ben Hamilton(where "this" is `base/containers/util.h` and `base/containers/checked_iterators.h`).
Sure, I can send a CL. I'm surprised it builds without that, but I'm not a `gn` expert.
Related details
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |