Fix Fuchsia build [crashpad/crashpad : main]

5 views
Skip to first unread message

Thomas Gales (Gerrit)

unread,
May 29, 2025, 12:15:59 PM5/29/25
to Avi Drissman, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Thomas Gales added 2 comments

Commit Message
Line 7, Patchset 3:Fix Fuchsia roller
Mark Mentovai . resolved

This fixes the Fuchsia build. The roller is an implementation detail.

Thomas Gales

Done

Line 12, Patchset 3:Bug: chromium:40173260
Mark Mentovai . resolved

Crashpad and Chromium share a bug namespace now, so the chromium: prefix isn’t necessary.

Thomas Gales

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 29 May 2025 16:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 29, 2025, 12:17:42 PM5/29/25
to Thomas Gales, Avi Drissman, crashp...@chromium.org
Attention needed from Thomas Gales

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Thu, 29 May 2025 16:17:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Gales (Gerrit)

unread,
May 29, 2025, 12:17:53 PM5/29/25
to Mark Mentovai, Avi Drissman, crashp...@chromium.org

Thomas Gales voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Thu, 29 May 2025 16:17:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 29, 2025, 12:27:15 PM5/29/25
to Thomas Gales, Mark Mentovai, Avi Drissman, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Fix Fuchsia build

//testing/buildbot/filters:crashpad_tests_filters is defined downstream
by Chromium.
Bug: 40173260
Fixed: 421124307
Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Thomas Gales <tga...@google.com>
Reviewed-by: Avi Drissman <a...@chromium.org>
Files:
  • M BUILD.gn
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Avi Drissman, +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement

Jullian Wells (Gerrit)

unread,
Jun 5, 2025, 4:26:07 PM6/5/25
to Crashpad LUCI CQ, Thomas Gales, Mark Mentovai, Avi Drissman, crashp...@chromium.org

Jullian Wells voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jullian Wells <jullian...@gmail.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 20:22:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages