Yilong Yao (Gerrit)

unread,

Dec 1, 2025, 3:40:18 PMDec 1

to Joshua Peraza, Ivan Penkov, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Ivan Penkov and Joshua Peraza

Yilong Yao voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Ivan Penkov
Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Joshua Peraza (Gerrit)

unread,

Dec 1, 2025, 3:57:11 PMDec 1

to Yilong Yao, Mark Mentovai, Ivan Penkov, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai and Yilong Yao

Joshua Peraza added 2 comments

File handler/handler_main.cc

Line 96, Patchset 1 (Latest): BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_APPLE)

Joshua Peraza . unresolved

IS_MAC to not include iOS in this.

File handler/mac/crash_report_exception_handler.cc

Line 183, Patchset 1 (Latest):

      ScopedFileHandle handle(
          LoggingOpenFileForRead(attachment));
      if (!handle.is_valid()) {
        continue;
      }
      constexpr size_t kBufSize = 4096;
      char buf[kBufSize];
      FileOperationResult count;
      while ((count = ReadFile(handle.get(), buf, kBufSize)) > 0) {
        if (!writer->Write(buf, count)) {
          LOG(WARNING) << "Failed to write to attachment";
          break;
        }
      }
    }

Joshua Peraza . unresolved

Open the file with a FileReader and you can use CopyFileContent().

https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/util/file/file_reader.h;drc=9369044d135466db00f0abb5828f55821c0341d8;l=99
https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/util/file/file_helper.h;l=24

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai
Yilong Yao

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Ivan Penkov (Gerrit)

unread,

Dec 1, 2025, 4:08:09 PMDec 1

to Yilong Yao, Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza, Mark Mentovai and Yilong Yao

Ivan Penkov added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Ivan Penkov . resolved

Adding Mark to review the changes to the MacOS client.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai
Yilong Yao

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Yilong Yao (Gerrit)

unread,

Dec 1, 2025, 4:19:10 PMDec 1

to Mark Mentovai, Ivan Penkov, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza and Mark Mentovai

Yilong Yao added 2 comments

File handler/handler_main.cc

Line 96, Patchset 1: BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_APPLE)

Joshua Peraza . resolved

IS_MAC to not include iOS in this.

Yilong Yao

Done

File handler/mac/crash_report_exception_handler.cc

Line 183, Patchset 1: ScopedFileHandle handle(


          LoggingOpenFileForRead(attachment));
      if (!handle.is_valid()) {
        continue;
      }
      constexpr size_t kBufSize = 4096;
      char buf[kBufSize];
      FileOperationResult count;
      while ((count = ReadFile(handle.get(), buf, kBufSize)) > 0) {
        if (!writer->Write(buf, count)) {
          LOG(WARNING) << "Failed to write to attachment";
          break;
        }
      }
    }

Joshua Peraza . resolved

Open the file with a FileReader and you can use CopyFileContent().
https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/util/file/file_reader.h;drc=9369044d135466db00f0abb5828f55821c0341d8;l=99
https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/util/file/file_helper.h;l=24

Yilong Yao

Fix applied.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Yilong Yao (Gerrit)

unread,

Dec 1, 2025, 4:43:23 PMDec 1

to Mark Mentovai, Ivan Penkov, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza and Mark Mentovai

Yilong Yao added 1 comment

File handler/handler_main.cc

Line 96, Patchset 1: BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_APPLE)

Joshua Peraza . unresolved

IS_MAC to not include iOS in this.

Yilong Yao

Done

Yilong Yao

Note this seemed to require a few more #if guards in handler/mac/crash_report_exception_handler.cc to compile for iOS, making the code a bit messy. Open to any suggestions on how to keep the code clean.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Joshua Peraza (Gerrit)

unread,

Dec 1, 2025, 6:49:21 PMDec 1

to Yilong Yao, Mark Mentovai, Ivan Penkov, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai and Yilong Yao

Joshua Peraza added 1 comment

File handler/handler_main.cc

Line 96, Patchset 1: BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_APPLE)

Joshua Peraza . unresolved

IS_MAC to not include iOS in this.

Yilong Yao

Done

Yilong Yao

Note this seemed to require a few more #if guards in handler/mac/crash_report_exception_handler.cc to compile for iOS, making the code a bit messy. Open to any suggestions on how to keep the code clean.

Joshua Peraza

I think handler_main.cc and crash_report_exception_handler.cc shouldn't be used on iOS at all (I guess my initial comment wasn't needed). I think you could put the "handler" and "handler_test" targets in "if (!crashpad_is_ios) {}" blocks to avoid building this code on iOS.

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai
Yilong Yao

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Yilong Yao (Gerrit)

unread,

Dec 1, 2025, 8:07:50 PMDec 1

to Mark Mentovai, Ivan Penkov, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza and Mark Mentovai

Yilong Yao added 1 comment

File handler/handler_main.cc

Line 96, Patchset 1: BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_APPLE)

Joshua Peraza . resolved

IS_MAC to not include iOS in this.

Yilong Yao

Done

Yilong Yao

Note this seemed to require a few more #if guards in handler/mac/crash_report_exception_handler.cc to compile for iOS, making the code a bit messy. Open to any suggestions on how to keep the code clean.

Joshua Peraza

I think handler_main.cc and crash_report_exception_handler.cc shouldn't be used on iOS at all (I guess my initial comment wasn't needed). I think you could put the "handler" and "handler_test" targets in "if (!crashpad_is_ios) {}" blocks to avoid building this code on iOS.

Yilong Yao

Thanks! Done

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Joshua Peraza (Gerrit)

unread,

Dec 2, 2025, 11:44:46 AMDec 2

to Yilong Yao, AyeAye, Mark Mentovai, Ivan Penkov, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai and Yilong Yao

Joshua Peraza voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai
Yilong Yao

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yilong Yao (Gerrit)

unread,

Dec 3, 2025, 1:55:54 PMDec 3

to Joshua Peraza, AyeAye, Mark Mentovai, Ivan Penkov, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai

Yilong Yao added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Yilong Yao . resolved

Ping if there's anything I should change on this CL.

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ivan Penkov (Gerrit)

unread,

Dec 3, 2025, 3:49:10 PMDec 3

to Yilong Yao, Joshua Peraza, AyeAye, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai and Yilong Yao

Ivan Penkov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai
Yilong Yao

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Yilong Yao (Gerrit)

unread,

Dec 3, 2025, 3:50:45 PMDec 3

to Ivan Penkov, Joshua Peraza, AyeAye, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai

Yilong Yao voted and added 1 comment

Votes added by Yilong Yao

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Yilong Yao . resolved

Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Crashpad LUCI CQ (Gerrit)

unread,

Dec 3, 2025, 4:00:46 PMDec 3

to Yilong Yao, Ivan Penkov, Joshua Peraza, AyeAye, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:

Add support for attachments on macOS.

This change modifies the Crashpad client on macOS to accept a list of
file paths as attachments. These attachments are passed as arguments to
the handler process. The macOS exception handler is updated to read
these files and include them in the generated crash report.

DISALBE_SPELLCHECKER: Existing comment
Change-Id: Icf74714c76215ea61136287d1118ac3795d6f6d8
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7214128
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Reviewed-by: Ivan Penkov <iva...@google.com>
Commit-Queue: Yilong Yao <yilo...@google.com>

Files:

M client/crashpad_client_mac.cc
M handler/BUILD.gn
M handler/handler_main.cc
M handler/mac/crash_report_exception_handler.cc
M handler/mac/crash_report_exception_handler.h

Change size: L

Delta: 5 files changed, 166 insertions(+), 134 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ivan Penkov, +1 by Joshua Peraza

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Add support for attachments on macOS. [crashpad/crashpad : main]

Yilong Yao (Gerrit)

Yilong Yao voted Commit-Queue+1

Related details

Joshua Peraza (Gerrit)

Joshua Peraza added 2 comments

Related details

Ivan Penkov (Gerrit)

Ivan Penkov added 1 comment

Related details

Yilong Yao (Gerrit)

Yilong Yao added 2 comments

Related details

Yilong Yao (Gerrit)

Yilong Yao added 1 comment

Related details

Joshua Peraza (Gerrit)

Joshua Peraza added 1 comment

Related details

Yilong Yao (Gerrit)

Yilong Yao added 1 comment

Related details

Joshua Peraza (Gerrit)

Joshua Peraza voted Code-Review+1

Related details

Yilong Yao (Gerrit)

Yilong Yao added 1 comment

Related details

Ivan Penkov (Gerrit)

Ivan Penkov voted Code-Review+1

Related details

Yilong Yao (Gerrit)

Yilong Yao voted and added 1 comment

Votes added by Yilong Yao

1 comment

Related details

Crashpad LUCI CQ (Gerrit)

Crashpad LUCI CQ submitted the change

Change information