tvOS: Remove LOG() call from CrashHandler::DoInitialize() [crashpad/crashpad : main]
1 view
Skip to first unread message
Raphael Kubo da Costa (Gerrit)
May 15, 2025, 4:53:42 PM5/15/25
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai
Raphael Kubo da Costa added 1 comment![]( "Open in Gerrit")
File client/crash_handler_tvos.cc
Line 61, Patchset 1:
LOG(ERROR) << "Unable to install crash handlers";Mark Mentovai . resolved
Raphael Kubo da CostaYou can just get rid of this. InstallCrashHandlers promises to log the problem, and with more detail, too: it’ll tell you why `sigaction` failed, and for which signal.
That makes sense. I've repurposed the CL and updated the commit message.
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 15, 2025, 5:05:15 PM5/15/25
to Raphael Kubo da Costa, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Raphael Kubo da Costa
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Raphael Kubo da Costa
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
May 15, 2025, 5:35:01 PM5/15/25
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Raphael Kubo da Costa voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 15, 2025, 5:56:08 PM5/15/25
to Raphael Kubo da Costa, Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, cobalt-...@google.com, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
tvOS: Remove LOG() call from CrashHandler::DoInitialize()
This fixes a compilation error when building Crashpad in Chromium:
../../third_party/crashpad/crashpad/client/crash_handler_tvos.cc:60:9: error: use of undeclared identifier 'ERROR'
60 | LOG(ERROR) << "Unable to install crash handlers";
| ^~~~~
But most importantly, the call itself was not very useful since
InstallCrashHandlers() will already show a more descriptive error
message if sigaction() fails.
Bug: 405140658
Change-Id: If20186017e8202ddd355a416c2cc7ba8b8dd64cc
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Raphael Kubo da Costa <ku...@igalia.com>
Files:
- M client/crash_handler_tvos.cc
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages