ios: Handle dyld crashreporter_annotations_t in __DATA_DIRTY segment. [crashpad/crashpad : main]
8 views
Skip to first unread message
Justin Cohen (Gerrit)
Aug 4, 2025, 8:52:16 AMAug 4
to Mark Cogan, Crashpad LUCI CQ, crashp...@chromium.org
Justin Cohen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Aug 4, 2025, 9:01:42 AMAug 4
to Justin Cohen, Mark Cogan, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ios: Handle dyld crashreporter_annotations_t in __DATA_DIRTY segment.
On newer dyld versions, the `__crash_info` section is placed in the
`__DATA_DIRTY` segment. This change updates the crash handler to check
for this segment in addition to `SEG_DATA`.
Change-Id: Ie0eebf36c57db3e5267c4e3dcfae6eef488d52f3
Commit-Queue: Justin Cohen <justi...@chromium.org>
Reviewed-by: Mark Cogan <ma...@chromium.org>
Files:
- M client/ios_handler/in_process_intermediate_dump_handler.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Cogan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Aug 4, 2025, 9:02:50 AMAug 4
to Justin Cohen, Crashpad LUCI CQ, Mark Cogan, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
File client/ios_handler/in_process_intermediate_dump_handler.cc
Line 1122, Patchset 1:
// dyld puts __crash_info in __DATA_DIRTY.Mark Mentovai . unresolved
Not an absolute: it does in some versions, but not others.
If iOS 26 is like macOS 26, it's back to `__DATA` there.
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Cogan (Gerrit)
Aug 4, 2025, 9:33:09 AMAug 4
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Cogan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Cogan
| Code-Review | +1 |
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages