ios: Fallback to EXCEPTION_STATE_IDENTITY pre-iOS18. [crashpad/crashpad : main]
15 views
Skip to first unread message
Justin Cohen (Gerrit)
Apr 8, 2026, 10:14:25 AM (7 days ago) Apr 8
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Justin Cohen . resolved
Seems like I broke iOS 17 reports. I also noticed this exception_behaviors difference. Not sure if I need that as well.
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Apr 8, 2026, 11:03:31 AM (7 days ago) Apr 8
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Apr 8, 2026, 11:11:48 AM (7 days ago) Apr 8
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Justin Cohen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Apr 8, 2026, 11:26:59 AM (7 days ago) Apr 8
to Justin Cohen, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ios: Fallback to EXCEPTION_STATE_IDENTITY pre-iOS18.
EXCEPTION_STATE_IDENTITY_PROTECTED doesn't work on iOS 17. Add an
availability check so we fallback to EXCEPTION_STATE_IDENTITY.
Bug: 500683705
Change-Id: Ifd663c0e25a3bc892b893a5ed7d56520392e9e9f
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Justin Cohen <justi...@google.com>
Files:
- M client/crash_handler_ios.cc
Change size: S
Delta: 1 file changed, 9 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages