run_tests.py: Fix style after 8bbfddf3 [crashpad/crashpad : main]

1 view
Skip to first unread message

Raphael Kubo da Costa (Gerrit)

unread,
May 15, 2025, 6:48:27 AMMay 15
to Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Idacdb5bec127fe0346e218b34594f8bd9688b23d
Gerrit-Change-Number: 6550397
Gerrit-PatchSet: 1
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Thu, 15 May 2025 10:48:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 15, 2025, 6:54:37 AMMay 15
to Raphael Kubo da Costa, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen and Raphael Kubo da Costa

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
  • Raphael Kubo da Costa
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Idacdb5bec127fe0346e218b34594f8bd9688b23d
Gerrit-Change-Number: 6550397
Gerrit-PatchSet: 1
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Thu, 15 May 2025 10:54:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Raphael Kubo da Costa (Gerrit)

unread,
May 15, 2025, 6:56:46 AMMay 15
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Raphael Kubo da Costa voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Idacdb5bec127fe0346e218b34594f8bd9688b23d
Gerrit-Change-Number: 6550397
Gerrit-PatchSet: 1
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Thu, 15 May 2025 10:56:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 15, 2025, 6:57:17 AMMay 15
to Raphael Kubo da Costa, Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
run_tests.py: Fix style after 8bbfddf3

https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6421724
introduced a style change that is making `git-cl format` unhappy when
rolling Crashpad into Chromium.

Fix it here to make the whole process easier instead of having to port
the Chromium change here later.
Bug: 405140658
Change-Id: Idacdb5bec127fe0346e218b34594f8bd9688b23d
Commit-Queue: Raphael Kubo da Costa <ku...@igalia.com>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M build/run_tests.py
Change size: XS
Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Idacdb5bec127fe0346e218b34594f8bd9688b23d
Gerrit-Change-Number: 6550397
Gerrit-PatchSet: 2
Gerrit-Owner: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages