mach: Support raising EXCEPTION_STATE_IDENTITY_PROTECTED exceptions [crashpad/crashpad : main]
Justin Cohen (Gerrit)
Justin Cohen removed Parth from this change![]( "Open in Gerrit")
- Parth
Related details
- Justin Cohen
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen added 1 comment![]( "Open in Gerrit")
I'm not sure if this CL is necessary, but it was pointed out to me that I missed updating util/mach/symbolic_constants_mach.cc with the new exception types, which led to updating the tests, and then the exc_client.
I don't think we use any of this on the iOS side of things (unless iOS changes CrashHandler::CatchMachException to Forward exceptions to original_handlers_ -- there's still a TODO there)
WDYT?
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai added 1 comment![]( "Open in Gerrit")
There’s also EXCEPTION_IDENTITY_PROTECTED.
Crashpad already handles things like EXCEPTION_IDENTITY. Should it handle EXCEPTION_IDENTITY_PROTECTED too?
Related details
- Justin Cohen
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen added 1 comment![]( "Open in Gerrit")
There’s also EXCEPTION_IDENTITY_PROTECTED.
Crashpad already handles things like EXCEPTION_IDENTITY. Should it handle EXCEPTION_IDENTITY_PROTECTED too?
Is that useful for Crashpad? EXCEPTION_IDENTITY_PROTECTED does not carry thread state.
```
routine mach_exception_raise_identity_protected(
exception_port : mach_port_t;
thread_id : uint64_t;
task_id_token_t : mach_port_t;
exception : exception_type_t;
code : mach_exception_data_t
);
```
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SLSA Policy Verification Service (Gerrit)
SLSA Policy Verification Service voted SLSA-Policy-Verified+1![]( "Open in Gerrit")
| SLSA-Policy-Verified | +1 |
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai added 2 comments![]( "Open in Gerrit")
Justin CohenThere’s also EXCEPTION_IDENTITY_PROTECTED.
Crashpad already handles things like EXCEPTION_IDENTITY. Should it handle EXCEPTION_IDENTITY_PROTECTED too?
Is that useful for Crashpad? EXCEPTION_IDENTITY_PROTECTED does not carry thread state.
```
routine mach_exception_raise_identity_protected(
exception_port : mach_port_t;
thread_id : uint64_t;
task_id_token_t : mach_port_t;
exception : exception_type_t;
code : mach_exception_data_t
);
```
Is that useful for Crashpad? EXCEPTION_IDENTITY_PROTECTED does not carry thread state.
Same situation as for `EXCEPTION_IDENTITY`, which Crashpad does implement.
If receiving an identity-only behavior, Crashpad will make an extra call to look up the thread state.
It’s also valid in case Crashpad needs to forward to an exception handler with this behavior.
return KERN_NOT_SUPPORTED;Add a comment saying that `EXCEPTION_IDENTITY_PROTECTED | kMachExceptionCodes` could be viable, but isn’t implemented for (insert reason). This is in contrast to the other two, which aren‘t viable combinations.
Related details
- Justin Cohen
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |