Remove remaining references to StringPiece [chromium/mini_chromium : main]
1 view
Skip to first unread message
Mark Mentovai (Gerrit)
Aug 15, 2025, 3:42:27 PMAug 15
to Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
File base/strings/string_number_conversions.cc
Line 189, Patchset 2 (Latest):
typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator, int, 10>Mark Mentovai . unresolved
`git cl format`
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Aug 15, 2025, 3:54:47 PMAug 15
to Mark Mentovai, crashp...@chromium.org
Joshua Peraza added 1 comment![]( "Open in Gerrit")
File base/strings/string_number_conversions.cc
Line 189, Patchset 2:
typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator, int, 10>Mark Mentovai . resolved
Joshua Peraza`git cl format`
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Aug 15, 2025, 3:54:55 PMAug 15
to Mark Mentovai, crashp...@chromium.org
Joshua Peraza submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/strings/string_number_conversions.cc
Insertions: 5, Deletions: 3.
@@ -186,12 +186,14 @@
static constexpr int kBase = BASE;
};
-typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator, int, 10>
+typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator,
+ int,
+ 10>
IteratorRangeToIntTraits;
typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator,
- unsigned int,
- 10>
+ unsigned int,
+ 10>
IteratorRangeToUintTraits;
typedef BaseIteratorRangeToNumberTraits<std::string_view::const_iterator,
```
Change information
Commit message:
Remove remaining references to StringPiece
Change-Id: I43ab5738e14e9bf8a4837f706f9d04887d09c84d
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M base/BUILD.gn
- M base/strings/string_number_conversions.cc
- D base/strings/string_piece.h
Change size: M
Delta: 3 files changed, 10 insertions(+), 211 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages