tvOS: Document differences from iOS [crashpad/crashpad : main]
5 views
Skip to first unread message
Raphael Kubo da Costa (Gerrit)
Jul 9, 2025, 8:23:49 AM7/9/25
to Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Justin Cohen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 9, 2025, 8:34:30 AM7/9/25
to Raphael Kubo da Costa, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Justin Cohen and Raphael Kubo da Costa
Mark Mentovai added 2 comments![]( "Open in Gerrit")
File doc/ios_overview_design.md
Line 183, Patchset 1 (Latest):
the `mach_msg()` APIs (they are forbidden at build-time) so using MachMark Mentovai . unresolved
“(they are forbidden at build-time)” doesn’t contribute to the point. And as the work you just did on `posix_spawn` shows, “forbidden” can be flexible. You can remove this.
Line 187, Patchset 1 (Latest):
handler is initialized; the tvOS handler can use the POSIX signals andMark Mentovai . unresolved
You’re saying that tvOS _can_ use these, but you should say how it _does_. In particular, iOS Crashpad uses signals for some things. Is a reader supposed to understand that tvOS Crashpad uses signals for those same things? Or does it additionally use signals to cover part of what iOS Crashpad uses Mach recordings for?
Related details
Attention is currently required from:
- Justin Cohen
- Raphael Kubo da Costa
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
Jul 9, 2025, 8:46:12 AM7/9/25
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Raphael Kubo da Costa added 2 comments![]( "Open in Gerrit")
File doc/ios_overview_design.md
Line 183, Patchset 1:
the `mach_msg()` APIs (they are forbidden at build-time) so using MachMark Mentovai . resolved
“(they are forbidden at build-time)” doesn’t contribute to the point. And as the work you just did on `posix_spawn` shows, “forbidden” can be flexible. You can remove this.
Raphael Kubo da Costa
Done
Line 187, Patchset 1:
handler is initialized; the tvOS handler can use the POSIX signals andMark Mentovai . resolved
You’re saying that tvOS _can_ use these, but you should say how it _does_. In particular, iOS Crashpad uses signals for some things. Is a reader supposed to understand that tvOS Crashpad uses signals for those same things? Or does it additionally use signals to cover part of what iOS Crashpad uses Mach recordings for?
Raphael Kubo da Costa
I think I've addressed this one by explaining what the POSIX signal handler can and cannot do.
Related details
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 9, 2025, 10:06:26 AM7/9/25
to Raphael Kubo da Costa, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Justin Cohen and Raphael Kubo da Costa
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Justin Cohen
- Raphael Kubo da Costa
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
Jul 9, 2025, 10:16:58 AM7/9/25
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Attention needed from Justin Cohen
Raphael Kubo da Costa voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Kubo da Costa (Gerrit)
Jul 9, 2025, 10:32:08 AM7/9/25
to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, cobalt-...@google.com, crashp...@chromium.org
Raphael Kubo da Costa submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
tvOS: Document differences from iOS
Explain that most of iOS's architecture and constraints apply, but tvOS
is unable to monitor and catch Mach exceptions.
Bug: 405140658
Change-Id: I3ce406374f8a4aad85ab367b807e980651fe5935
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M doc/ios_overview_design.md
Change size: S
Delta: 1 file changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages