Roll xnu to 12377.1.9 (from macOS 26.0.0) [crashpad/crashpad : main]

4 views
Skip to first unread message

Justin Cohen (Gerrit)

unread,
Nov 25, 2025, 2:23:48 PMNov 25
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Justin Cohen added 2 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Justin Cohen . resolved

Aside from running this through the CQ -- what else should I should?

File third_party/xnu/EXTERNAL_HEADERS/mach-o/loader.h
Line 46, Patchset 5 (Latest):#include <mach/machine/thread_status.h>
#include <architecture/byte_order.h>
*/
Justin Cohen . unresolved

I kept this local change, although I'm not sure why it's necessary.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
Gerrit-Change-Number: 7205002
Gerrit-PatchSet: 5
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 19:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Nov 25, 2025, 3:04:25 PMNov 25
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Mark Mentovai added 4 comments

Commit Message
Line 7, Patchset 5 (Latest):Roll xnu to 12377.1.9 (from macOS 26.0.0)
Mark Mentovai . unresolved

Just 26.0.

File third_party/xnu/EXTERNAL_HEADERS/mach-o/loader.h
Line 46, Patchset 5 (Latest):#include <mach/machine/thread_status.h>
#include <architecture/byte_order.h>
*/
Justin Cohen . resolved

I kept this local change, although I'm not sure why it's necessary.

Mark Mentovai

I kept this local change, although I'm not sure why it's necessary.

We have `<mach/machine.h>` and `<mach/vm_prot.h>` stubs in compat/non_mac (which might be properly rename-able to compat/non_apple now). That makes this `<mach-o/loader.h>` usable on all OS platforms. This was important to me for a future project that never quite got off the ground. It might become important again someday.

We don’t have `<mach/machine/thread_status.h>` or `<architecture/byte_order.h>` stubs in compat/non_apple. Nothing against adding them, but they’re a little spidery, and since `<mach-o/loader.h>` actually doesn’t need anything from them, there was no reason to keep these `#include`s intact.

File third_party/xnu/README.crashpad
Line 4, Patchset 5 (Latest):Version: 12377.1.9 (from macOS 26.0.0)
Mark Mentovai . unresolved

Just 26.0 here too.

File third_party/xnu/osfmk/mach/std_types.defs
Line 65, Patchset 5 (Latest):import <Availability.h>;
Mark Mentovai . unresolved

Wonder if this needs special handling. How does this transform the output?

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ibb090c6c6a25f58870b7f8d64437b1d67f95e7d4
Gerrit-Change-Number: 7205002
Gerrit-PatchSet: 5
Gerrit-Owner: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 20:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin Cohen <justi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages