Crashpad: AnnotationList: Spell check a random word in annotation_list.h [crashpad/crashpad : main]
Solomon Kinard (Gerrit)
Solomon Kinard added 1 comment![]( "Open in Gerrit")
Review? Reference [here](https://chromium-review.googlesource.com/c/chromium/src/+/6719473/comment/5cda037f_b12ec0d9). Carrying forward a question posed there:
What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Review? Reference [here](https://chromium-review.googlesource.com/c/chromium/src/+/6719473/comment/5cda037f_b12ec0d9). Carrying forward a question posed there:
What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.
Review? Reference [here](https://chromium-review.googlesource.com/c/chromium/src/+/6719473/comment/5cda037f_b12ec0d9). Carrying forward a question posed there:
What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.What can be done systemically to prevent inadvertent fork changes of third party code? e.g. perhaps a presubmit warning for the uninitiated.
The question is relevant to Chromium’s use of Crashpad, not Crashpad proper, so I’ll answer it there.
Related details
- Solomon Kinard
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Solomon Kinard (Gerrit)
Solomon Kinard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Solomon Kinard
| Commit-Queue | +2 |
1 comment
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Solomon Kinard (Gerrit)
Solomon Kinard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Solomon Kinard
| Commit-Queue | +2 |
1 comment
Thanks. This CL is now able to merge because I asked for crrev.com/c/6729599 to be created, which has also now been merged.
Related details
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Crashpad: AnnotationList: Spell check a random word in annotation_list.h
- M client/annotation_list.h
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |